Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: webrtc/modules/congestion_controller/transport_feedback_adapter.h

Issue 2725823002: Move delay_based_bwe_ into CongestionController (Closed)
Patch Set: UT thread-checking. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #ifndef WEBRTC_MODULES_CONGESTION_CONTROLLER_TRANSPORT_FEEDBACK_ADAPTER_H_ 11 #ifndef WEBRTC_MODULES_CONGESTION_CONTROLLER_TRANSPORT_FEEDBACK_ADAPTER_H_
12 #define WEBRTC_MODULES_CONGESTION_CONTROLLER_TRANSPORT_FEEDBACK_ADAPTER_H_ 12 #define WEBRTC_MODULES_CONGESTION_CONTROLLER_TRANSPORT_FEEDBACK_ADAPTER_H_
13 13
14 #include <memory>
15 #include <vector> 14 #include <vector>
16 15
17 #include "webrtc/base/criticalsection.h" 16 #include "webrtc/base/criticalsection.h"
18 #include "webrtc/base/thread_annotations.h" 17 #include "webrtc/base/thread_annotations.h"
19 #include "webrtc/base/thread_checker.h" 18 #include "webrtc/base/thread_checker.h"
20 #include "webrtc/modules/congestion_controller/delay_based_bwe.h"
21 #include "webrtc/modules/include/module_common_types.h"
22 #include "webrtc/modules/remote_bitrate_estimator/include/send_time_history.h" 19 #include "webrtc/modules/remote_bitrate_estimator/include/send_time_history.h"
20 #include "webrtc/system_wrappers/include/clock.h"
23 21
24 namespace webrtc { 22 namespace webrtc {
25 23
26 class BitrateController; 24 namespace rtcp {
27 class RtcEventLog; 25 class TransportFeedback;
28 class ProcessThread; 26 } // namespace rtcp
29 27
30 class TransportFeedbackAdapter : public TransportFeedbackObserver, 28 class TransportFeedbackAdapter {
31 public CallStatsObserver {
32 public: 29 public:
33 TransportFeedbackAdapter(RtcEventLog* event_log, 30 explicit TransportFeedbackAdapter(Clock* clock);
34 Clock* clock,
35 BitrateController* bitrate_controller);
36 virtual ~TransportFeedbackAdapter(); 31 virtual ~TransportFeedbackAdapter();
37 32
38 void InitBwe();
39 // Implements TransportFeedbackObserver.
40 void AddPacket(uint16_t sequence_number, 33 void AddPacket(uint16_t sequence_number,
41 size_t length, 34 size_t length,
42 const PacedPacketInfo& pacing_info) override; 35 const PacedPacketInfo& pacing_info);
43 void OnSentPacket(uint16_t sequence_number, int64_t send_time_ms); 36 void OnSentPacket(uint16_t sequence_number, int64_t send_time_ms);
44 37
45 // TODO(holmer): This method should return DelayBasedBwe::Result so that we 38 // TODO(holmer): This method should return DelayBasedBwe::Result so that we
46 // can get rid of the dependency on BitrateController. Requires changes 39 // can get rid of the dependency on BitrateController. Requires changes
47 // to the CongestionController interface. 40 // to the CongestionController interface.
48 void OnTransportFeedback(const rtcp::TransportFeedback& feedback) override; 41 void OnTransportFeedback(const rtcp::TransportFeedback& feedback);
49 std::vector<PacketFeedback> GetTransportFeedbackVector() const override; 42 std::vector<PacketFeedback> GetTransportFeedbackVector() const;
50 43
51 // Implements CallStatsObserver.
52 void OnRttUpdate(int64_t avg_rtt_ms, int64_t max_rtt_ms) override;
53
54 void SetStartBitrate(int start_bitrate_bps);
55 void SetMinBitrate(int min_bitrate_bps);
56 void SetTransportOverhead(int transport_overhead_bytes_per_packet); 44 void SetTransportOverhead(int transport_overhead_bytes_per_packet);
57 45
58 int64_t GetProbingIntervalMs() const;
59
60 void ClearSendTimeHistory(); 46 void ClearSendTimeHistory();
61 47
62 private: 48 private:
63 std::vector<PacketFeedback> GetPacketFeedbackVector( 49 std::vector<PacketFeedback> GetPacketFeedbackVector(
64 const rtcp::TransportFeedback& feedback); 50 const rtcp::TransportFeedback& feedback);
65 51
66 const bool send_side_bwe_with_overhead_; 52 const bool send_side_bwe_with_overhead_;
67 rtc::CriticalSection lock_; 53 rtc::CriticalSection lock_;
68 rtc::CriticalSection bwe_lock_;
69 int transport_overhead_bytes_per_packet_ GUARDED_BY(&lock_); 54 int transport_overhead_bytes_per_packet_ GUARDED_BY(&lock_);
70 SendTimeHistory send_time_history_ GUARDED_BY(&lock_); 55 SendTimeHistory send_time_history_ GUARDED_BY(&lock_);
71 std::unique_ptr<DelayBasedBwe> delay_based_bwe_ GUARDED_BY(&bwe_lock_); 56 const Clock* const clock_;
72 RtcEventLog* const event_log_;
73 Clock* const clock_;
74 int64_t current_offset_ms_; 57 int64_t current_offset_ms_;
75 int64_t last_timestamp_us_; 58 int64_t last_timestamp_us_;
76 BitrateController* const bitrate_controller_;
77 std::vector<PacketFeedback> last_packet_feedback_vector_; 59 std::vector<PacketFeedback> last_packet_feedback_vector_;
78 }; 60 };
79 61
80 } // namespace webrtc 62 } // namespace webrtc
81 63
82 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_TRANSPORT_FEEDBACK_ADAPTER_H_ 64 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_TRANSPORT_FEEDBACK_ADAPTER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698