Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: webrtc/common_video/video_render_frames.cc

Issue 2724823004: Drop out of order frames in VideoRenderFrames. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/common_video/video_render_frames.cc
diff --git a/webrtc/common_video/video_render_frames.cc b/webrtc/common_video/video_render_frames.cc
index 444347d205cab68ae69f95e20b0108617ccad61f..31415c53069d54af98603a586e748038d7a0ea6f 100644
--- a/webrtc/common_video/video_render_frames.cc
+++ b/webrtc/common_video/video_render_frames.cc
@@ -67,8 +67,9 @@ int32_t VideoRenderFrames::AddFrame(VideoFrame&& new_frame) {
"%s: frame scheduled out of order, render_time=%u, latest=%u.",
__FUNCTION__, new_frame.render_time_ms(),
last_render_time_ms_);
- // TODO(mflodman): Decide what to do when this happens.
- // See bug: https://bugs.chromium.org/p/webrtc/issues/detail?id=7253
+ // For more details, see bug:
+ // https://bugs.chromium.org/p/webrtc/issues/detail?id=7253
+ return -1;
}
last_render_time_ms_ = new_frame.render_time_ms();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698