Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: webrtc/sdk/BUILD.gn

Issue 2723903003: Add unit tests for RTCMTLVideoView. (Closed)
Patch Set: Fix property vs ivar use Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index 4acf3783f545259ac77f82027932f9ba2a03628d..77621d7a327acde29d64cf686ad51d6b2c584c2c 100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -94,6 +94,7 @@ if (is_ios || is_mac) {
rtc_static_library("rtc_sdk_peerconnection_objc") {
sources = [
+ "objc/Framework/Classes/Metal/RTCMTLNV12Renderer.h",
"objc/Framework/Classes/RTCAVFoundationVideoCapturerInternal.h",
"objc/Framework/Classes/RTCAVFoundationVideoCapturerInternal.mm",
"objc/Framework/Classes/RTCAVFoundationVideoSource+Private.h",
@@ -253,10 +254,14 @@ if (is_ios || is_mac) {
"objc/Framework/UnitTests/RTCDataChannelConfigurationTest.mm",
"objc/Framework/UnitTests/RTCIceCandidateTest.mm",
"objc/Framework/UnitTests/RTCIceServerTest.mm",
+ "objc/Framework/UnitTests/RTCMTLVideoViewTests.mm",
"objc/Framework/UnitTests/RTCMediaConstraintsTest.mm",
"objc/Framework/UnitTests/RTCSessionDescriptionTest.mm",
"objc/Framework/UnitTests/avformatmappertests.mm",
]
+ if (current_cpu != "arm64") {
kthelgason 2017/03/02 08:23:05 Isn't this conditional the wrong way around?
+ sources += [ "objc/Framework/Classes/Metal/RTCMTLVideoView.m" ]
magjed_webrtc 2017/03/02 13:28:18 Is it ok to always do: sources += [ "objc/Framewor
daniela-webrtc 2017/03/03 08:47:01 Yes, it's added twice for arm64 in that case and c
+ }
deps = [
":rtc_sdk_peerconnection_objc",
"//third_party/ocmock",

Powered by Google App Engine
This is Rietveld 408576698