Add unit tests for RTCMTLVideoView.

webrtc/sdk/objc/Framework/Classes/Metal/RTCMTLVideoView.m

 /*
  *  Copyright 2017 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #import "WebRTC/RTCMTLVideoView.h"
 
 #import <Metal/Metal.h>
 #import <MetalKit/MetalKit.h>
 
 #import "WebRTC/RTCLogging.h"
 #import "WebRTC/RTCVideoFrame.h"
 
 #import "RTCMTLNV12Renderer.h"
 
+// To avoid unreconized symbol linker errors, we're taking advantage of the objc runtime.
+// Linking errors occur when compiling for architectures that don't support Metal.
+#define MTKViewClass NSClassFromString(@"MTKView")
+#define RTCMTLNV12RendererClass NSClassFromString(@"RTCMTLNV12Renderer")

[kthelgason, 2017/03/02 08:23:05]

This frightens me a little bit. Can't we just not compile this file on
architectures without metal?

+
 @interface RTCMTLVideoView () <MTKViewDelegate>
 @property(nonatomic, strong) id<RTCMTLRenderer> renderer;
-@property(nonatomic, strong) MTKView *metalView;
+@property(nonatomic, strong) UIView *metalView;

[magjed_webrtc, 2017/03/02 13:28:18]

Why can't this still be an MTKView when we mock it?

[daniela-webrtc, 2017/03/03 08:47:01]

I thought it will give linking errors when using the proper type, but I was
wrong :) Thanks for pointing it out.

 @property(atomic, strong) RTCVideoFrame *videoFrame;
 @end
 
-@implementation RTCMTLVideoView {
-  id<RTCMTLRenderer> _renderer;
-}
+@implementation RTCMTLVideoView
 
 @synthesize renderer = _renderer;
 @synthesize metalView = _metalView;
 @synthesize videoFrame = _videoFrame;
 
 - (instancetype)initWithFrame:(CGRect)frameRect {
   self = [super initWithFrame:frameRect];
   if (self) {
     [self configure];
   }
@@ skipping 11 matching lines @@
 #pragma mark - Private
 
 + (BOOL)isMetalAvailable {
 #if defined(__OBJC__) && COREVIDEO_SUPPORTS_METAL
   return YES;
 #elif
   return NO;
 #endif
 }
 
++ (UIView *)createMetalView:(CGRect)frame {
+  UIView *view = [[MTKViewClass alloc] initWithFrame:frame];
+  return view;
+}
+
++ (id<RTCMTLRenderer>)createMetalRenderer {
+  id<RTCMTLRenderer> renderer = [[RTCMTLNV12RendererClass alloc] init];
+  return renderer;
+}
+
 - (void)configure {
-  if ([RTCMTLVideoView isMetalAvailable]) {
-    _metalView = [[MTKView alloc] initWithFrame:self.bounds];
-    [self addSubview:_metalView];
-    _metalView.delegate = self;
-    _metalView.contentMode = UIViewContentModeScaleAspectFit;
-    _metalView.translatesAutoresizingMaskIntoConstraints = NO;
-    UILayoutGuide *margins = self.layoutMarginsGuide;
-    [_metalView.topAnchor constraintEqualToAnchor:margins.topAnchor].active = YES;
-    [_metalView.bottomAnchor constraintEqualToAnchor:margins.bottomAnchor].active = YES;
-    [_metalView.leftAnchor constraintEqualToAnchor:margins.leftAnchor].active = YES;
-    [_metalView.rightAnchor constraintEqualToAnchor:margins.rightAnchor].active = YES;
+  if (![RTCMTLVideoView isMetalAvailable]) {
+    RTCLog("Metal unavailable");
+    return;
+  }
 
-    _renderer = [[RTCMTLNV12Renderer alloc] init];
-    if (![(RTCMTLNV12Renderer *)_renderer addRenderingDestination:_metalView]) {
-      _renderer = nil;
-    };
+  _metalView = [RTCMTLVideoView createMetalView:self.bounds];
+  _renderer = [RTCMTLVideoView createMetalRenderer];
+
+  if ([self configureMetalRenderer]) {
+    [self configureMetalView];
   } else {
+    _renderer = nil;
     RTCLogError("Metal configuration falied.");
   }
 }
+
+- (BOOL)configureMetalRenderer {
+  BOOL configurationSuccessful = NO;
+  if ([_renderer addRenderingDestination:_metalView]) {

[magjed_webrtc, 2017/03/02 13:28:18]

do:
return [_renderer addRenderingDestination:_metalView];
instead

[daniela-webrtc, 2017/03/03 08:47:01]

Done.

+    configurationSuccessful = YES;
+  };
+  return configurationSuccessful;
+}
+
+- (void)configureMetalView {
+  if (_metalView) {
+    MTKView *metalView = (MTKView *)_metalView;
+    metalView.delegate = self;
+    [self addSubview:metalView];
+    metalView.contentMode = UIViewContentModeScaleAspectFit;
+    metalView.translatesAutoresizingMaskIntoConstraints = NO;
+    UILayoutGuide *margins = self.layoutMarginsGuide;
+    [metalView.topAnchor constraintEqualToAnchor:margins.topAnchor].active = YES;
+    [metalView.bottomAnchor constraintEqualToAnchor:margins.bottomAnchor].active = YES;
+    [metalView.leftAnchor constraintEqualToAnchor:margins.leftAnchor].active = YES;
+    [metalView.rightAnchor constraintEqualToAnchor:margins.rightAnchor].active = YES;
+  }
+}
+
 #pragma mark - MTKViewDelegate methods
 
 - (void)drawInMTKView:(nonnull MTKView *)view {
   NSAssert(view == self.metalView, @"Receiving draw callbacks from foreign instance.");
-  [_renderer drawFrame:self.videoFrame];
+  [self.renderer drawFrame:self.videoFrame];
 }
 
 - (void)mtkView:(MTKView *)view drawableSizeWillChange:(CGSize)size {
 }
 
 #pragma mark - RTCVideoRenderer
 
 - (void)setSize:(CGSize)size {
-  _metalView.drawableSize = size;
-  [_metalView draw];
+  MTKView *metalView = (MTKView *)self.metalView;
+  metalView.drawableSize = size;
+  [metalView draw];
 }
 
 - (void)renderFrame:(nullable RTCVideoFrame *)frame {
   if (frame == nil) {
     RTCLogInfo(@"Incoming frame is nil. Exiting render callback.");
     return;
   }
   self.videoFrame = frame;
 }
 
 @end