Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2005)

Unified Diff: webrtc/p2p/base/packetlossestimator_unittest.cc

Issue 2722933002: Measure packet loss so we can use it to select ICE candidate pairs. (Closed)
Patch Set: Don't update the response rate when forgetting old requests + style feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/p2p/base/packetlossestimator_unittest.cc
diff --git a/webrtc/p2p/base/packetlossestimator_unittest.cc b/webrtc/p2p/base/packetlossestimator_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..a796714ef45b7c1d26d47e1535658bba34cbf4cb
--- /dev/null
+++ b/webrtc/p2p/base/packetlossestimator_unittest.cc
@@ -0,0 +1,122 @@
+/*
+ * Copyright 2017 The WebRTC Project Authors. All rights reserved.
+ *
+ * Use of this source code is governed by a BSD-style license
+ * that can be found in the LICENSE file in the root of the source
+ * tree. An additional intellectual property rights grant can be found
+ * in the file PATENTS. All contributing project authors may
+ * be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include <utility>
+
+#include "webrtc/base/gunit.h"
+#include "webrtc/p2p/base/packetlossestimator.h"
+
+using cricket::PacketLossEstimator;
+
+class PacketLossEstimatorTest : public testing::Test {};
+
+TEST_F(PacketLossEstimatorTest, InitialResponseRate) {
+ PacketLossEstimator ple(5, 100);
+ EXPECT_EQ(1.0, ple.get_response_rate());
+}
+
+TEST_F(PacketLossEstimatorTest, InitialUpdateResponseRate) {
+ PacketLossEstimator ple(5, 100);
+ ple.UpdateResponseRate(10);
+ EXPECT_EQ(1.0, ple.get_response_rate());
+}
+
+TEST_F(PacketLossEstimatorTest, ResponseReceived) {
+ PacketLossEstimator ple(5, 100);
+
+ ple.ExpectResponse("a", 0);
+ ple.ReceivedResponse("a", 1);
+ ple.UpdateResponseRate(2);
+
+ EXPECT_EQ(1.0, ple.get_response_rate());
+}
+
+TEST_F(PacketLossEstimatorTest, ResponseNotConsideredLostYet) {
+ PacketLossEstimator ple(5, 100);
+
+ ple.ExpectResponse("a", 0);
+ ple.UpdateResponseRate(2);
+
+ EXPECT_EQ(1.0, ple.get_response_rate());
+}
+
+TEST_F(PacketLossEstimatorTest, ResponseConsideredLost) {
+ PacketLossEstimator ple(5, 100);
+
+ ple.ExpectResponse("a", 0);
+ ple.UpdateResponseRate(10);
+
+ EXPECT_EQ(0.0, ple.get_response_rate());
+}
+
+TEST_F(PacketLossEstimatorTest, ResponseLate) {
+ PacketLossEstimator ple(5, 100);
+
+ ple.ExpectResponse("a", 0);
+ ple.ReceivedResponse("a", 6);
+ ple.UpdateResponseRate(10);
+
+ EXPECT_EQ(1.0, ple.get_response_rate());
+}
+
+TEST_F(PacketLossEstimatorTest, ResponseForgotten) {
+ PacketLossEstimator ple(5, 100);
+ ple.ExpectResponse("a", 0);
+ ple.UpdateResponseRate(101);
+
+ EXPECT_EQ(1.0, ple.get_response_rate());
+}
+
+TEST_F(PacketLossEstimatorTest, Lost1_Received1) {
+ PacketLossEstimator ple(5, 100);
+
+ ple.ExpectResponse("a", 0);
+ ple.ExpectResponse("b", 2);
+ ple.ReceivedResponse("b", 6);
+ ple.UpdateResponseRate(7);
+
+ EXPECT_EQ(0.5, ple.get_response_rate());
+}
+
+static const std::pair<std::string, int64_t> kFivePackets[5] = {{"a", 0},
+ {"b", 2},
+ {"c", 4},
+ {"d", 6},
+ {"e", 8}};
+
+// Time: 0 1 2 3 4 5 6 7 8 9 10
+// Sent: a b c d e
+// Recv: b
+// Wind: -------------->
+TEST_F(PacketLossEstimatorTest, Lost3_Received1_Waiting1) {
+ PacketLossEstimator ple(3, 100);
+
+ for (const auto& p : kFivePackets) {
+ ple.ExpectResponse(p.first, p.second);
+ }
+ ple.ReceivedResponse("b", 3);
+ ple.UpdateResponseRate(10);
+ EXPECT_EQ(0.25, ple.get_response_rate());
+}
+
+// Time: 0 1 2 3 4 5 6 7 8 9 10
+// Sent: a b c d e
+// Recv: c
+// Wind: <------->
+TEST_F(PacketLossEstimatorTest, Forgot2_Received1_Lost1_Waiting1) {
+ PacketLossEstimator ple(3, 7);
+
+ for (const auto& p : kFivePackets) {
+ ple.ExpectResponse(p.first, p.second);
+ }
+ ple.ReceivedResponse("c", 5);
+ ple.UpdateResponseRate(10);
+ EXPECT_EQ(0.5, ple.get_response_rate());
+}

Powered by Google App Engine
This is Rietveld 408576698