webrtc/pc/externalhmac.h - Issue 2722423003: Improve testing of SRTP external auth code paths.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/pc/externalhmac.h

Issue 2722423003: Improve testing of SRTP external auth code paths. (Closed)

Patch Set: Changes based on feedback from Taylor. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/pc/externalhmac.h

diff --git a/webrtc/pc/externalhmac.h b/webrtc/pc/externalhmac.h

index 2666d90cb8ee718063ed561e26edbd14e8fad11c..c0f2ce1ff6fe37e8b3d6ea2f984428e211c7bfcc 100644

--- a/webrtc/pc/externalhmac.h

+++ b/webrtc/pc/externalhmac.h

@@ -34,7 +34,7 @@

#include "third_party/libsrtp/crypto/include/auth.h"

#endif // HAVE_SRTP

-#if defined(HAVE_SRTP) && defined(ENABLE_EXTERNAL_AUTH)

+#if defined(HAVE_SRTP)

#define EXTERNAL_HMAC_SHA1 SRTP_HMAC_SHA1 + 1

#define HMAC_KEY_LENGTH 20

@@ -71,5 +71,5 @@ srtp_err_status_t external_hmac_compute(ExternalHmacContext* state,

srtp_err_status_t external_crypto_init();

-#endif // defined(HAVE_SRTP) && defined(ENABLE_EXTERNAL_AUTH)

+#endif // defined(HAVE_SRTP)

#endif // WEBRTC_PC_EXTERNALHMAC_H_

« no previous file with comments | « webrtc/pc/channel.cc ('k') | webrtc/pc/externalhmac.cc » ('j') | no next file with comments »