Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: webrtc/pc/srtpfilter.h

Issue 2720663003: Support GCM ciphers even if ENABLE_EXTERNAL_AUTH is defined. (Closed)
Patch Set: Fixed win_x64 compile errors (added explicit casts). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/pc/channelmanager.cc ('k') | webrtc/pc/srtpfilter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/pc/srtpfilter.h
diff --git a/webrtc/pc/srtpfilter.h b/webrtc/pc/srtpfilter.h
index 06edddf80d97a4e6d1a8274c4710cb94c11fc4a6..46b9dea19f38400abdb38f56cabc2eeece1197fb 100644
--- a/webrtc/pc/srtpfilter.h
+++ b/webrtc/pc/srtpfilter.h
@@ -114,6 +114,13 @@ class SrtpFilter {
// Returns srtp overhead for rtp packets.
bool GetSrtpOverhead(int* srtp_overhead) const;
+#if defined(ENABLE_EXTERNAL_AUTH)
+ // A SRTP filter supports external creation of the auth tag if a non-GCM
+ // cipher is used. This method is only valid after the RTP params have
+ // been set.
+ bool IsExternalAuthActive() const;
+#endif
+
// Update the silent threshold (in ms) for signaling errors.
void set_signal_silent_time(int signal_silent_time_in_ms);
@@ -206,6 +213,13 @@ class SrtpSession {
int GetSrtpOverhead() const;
+#if defined(ENABLE_EXTERNAL_AUTH)
+ // A SRTP session supports external creation of the auth tag if a non-GCM
+ // cipher is used. This method is only valid after the RTP params have
+ // been set.
+ bool IsExternalAuthActive() const;
+#endif
+
// Update the silent threshold (in ms) for signaling errors.
void set_signal_silent_time(int signal_silent_time_in_ms);
@@ -225,13 +239,16 @@ class SrtpSession {
static void HandleEventThunk(srtp_event_data_t* ev);
rtc::ThreadChecker thread_checker_;
- srtp_ctx_t_* session_;
- int rtp_auth_tag_len_;
- int rtcp_auth_tag_len_;
+ srtp_ctx_t_* session_ = nullptr;
+ int rtp_auth_tag_len_ = 0;
+ int rtcp_auth_tag_len_ = 0;
std::unique_ptr<SrtpStat> srtp_stat_;
static bool inited_;
static rtc::GlobalLockPod lock_;
- int last_send_seq_num_;
+ int last_send_seq_num_ = -1;
+#if defined(ENABLE_EXTERNAL_AUTH)
+ bool external_auth_active_ = false;
+#endif
RTC_DISALLOW_COPY_AND_ASSIGN(SrtpSession);
};
« no previous file with comments | « webrtc/pc/channelmanager.cc ('k') | webrtc/pc/srtpfilter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698