Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: webrtc/pc/channelmanager.cc

Issue 2720663003: Support GCM ciphers even if ENABLE_EXTERNAL_AUTH is defined. (Closed)
Patch Set: Fixed win_x64 compile errors (added explicit casts). Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/channel.cc ('k') | webrtc/pc/srtpfilter.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC project authors. All Rights Reserved. 2 * Copyright 2004 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 &ChannelManager::SetCryptoOptions_w, this, crypto_options)); 94 &ChannelManager::SetCryptoOptions_w, this, crypto_options));
95 } 95 }
96 96
97 bool ChannelManager::SetCryptoOptions_w( 97 bool ChannelManager::SetCryptoOptions_w(
98 const rtc::CryptoOptions& crypto_options) { 98 const rtc::CryptoOptions& crypto_options) {
99 if (!video_channels_.empty() || !voice_channels_.empty() || 99 if (!video_channels_.empty() || !voice_channels_.empty() ||
100 !data_channels_.empty()) { 100 !data_channels_.empty()) {
101 LOG(LS_WARNING) << "Not changing crypto options in existing channels."; 101 LOG(LS_WARNING) << "Not changing crypto options in existing channels.";
102 } 102 }
103 crypto_options_ = crypto_options; 103 crypto_options_ = crypto_options;
104 #if defined(ENABLE_EXTERNAL_AUTH)
105 if (crypto_options_.enable_gcm_crypto_suites) {
106 // TODO(jbauch): Re-enable once https://crbug.com/628400 is resolved.
107 crypto_options_.enable_gcm_crypto_suites = false;
108 LOG(LS_WARNING) << "GCM ciphers are not supported with " <<
109 "ENABLE_EXTERNAL_AUTH and will be disabled.";
110 }
111 #endif
112 return true; 104 return true;
113 } 105 }
114 106
115 void ChannelManager::GetSupportedAudioSendCodecs( 107 void ChannelManager::GetSupportedAudioSendCodecs(
116 std::vector<AudioCodec>* codecs) const { 108 std::vector<AudioCodec>* codecs) const {
117 *codecs = media_engine_->audio_send_codecs(); 109 *codecs = media_engine_->audio_send_codecs();
118 } 110 }
119 111
120 void ChannelManager::GetSupportedAudioReceiveCodecs( 112 void ChannelManager::GetSupportedAudioReceiveCodecs(
121 std::vector<AudioCodec>* codecs) const { 113 std::vector<AudioCodec>* codecs) const {
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 media_engine_.get(), file, max_size_bytes)); 443 media_engine_.get(), file, max_size_bytes));
452 } 444 }
453 445
454 void ChannelManager::StopAecDump() { 446 void ChannelManager::StopAecDump() {
455 worker_thread_->Invoke<void>( 447 worker_thread_->Invoke<void>(
456 RTC_FROM_HERE, 448 RTC_FROM_HERE,
457 Bind(&MediaEngineInterface::StopAecDump, media_engine_.get())); 449 Bind(&MediaEngineInterface::StopAecDump, media_engine_.get()));
458 } 450 }
459 451
460 } // namespace cricket 452 } // namespace cricket
OLDNEW
« no previous file with comments | « webrtc/pc/channel.cc ('k') | webrtc/pc/srtpfilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698