Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: webrtc/base/platform_thread_unittest.cc

Issue 2720223003: Add a DCHECK for PlatformThread instances that are too busy. (Closed)
Patch Set: Add comment for test Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/platform_thread.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/platform_thread_unittest.cc
diff --git a/webrtc/base/platform_thread_unittest.cc b/webrtc/base/platform_thread_unittest.cc
index d6d35e40e4955dfe82367ac29e3ed2de00c1efbf..415b9ebeb8a268fbd7dec0964b64c5e4e58fc9e6 100644
--- a/webrtc/base/platform_thread_unittest.cc
+++ b/webrtc/base/platform_thread_unittest.cc
@@ -17,7 +17,12 @@ namespace rtc {
namespace {
// Function that does nothing, and reports success.
bool NullRunFunctionDeprecated(void* obj) {
- webrtc::SleepMs(0); // Hand over timeslice, prevents busy looping.
+ webrtc::SleepMs(2); // Hand over timeslice, prevents busy looping.
+ return true;
+}
+
+bool TooBusyRunFunction(void* obj) {
+ // Indentionally busy looping.
return true;
}
@@ -108,4 +113,16 @@ TEST(PlatformThreadTest, RunFunctionIsCalled) {
EXPECT_TRUE(flag);
}
+// This test is disabled since it will cause a crash.
+// There might be a way to implement this as a death test, but it looks like
+// a death test requires an expression to be checked but does not allow a
+// flag to be raised that says "some thread will crash after this point".
+// TODO(tommi): Look into ways to enable the test by default.
+TEST(PlatformThreadTest, DISABLED_TooBusyDeprecated) {
+ PlatformThread thread(&TooBusyRunFunction, nullptr, "BusyThread");
+ thread.Start();
+ webrtc::SleepMs(1000);
+ thread.Stop();
+}
+
} // rtc
« no previous file with comments | « webrtc/base/platform_thread.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698