Add a DCHECK for PlatformThread instances that are too busy.

webrtc/base/platform_thread.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/base/platform_thread.h"
 
+#include <inttypes.h>

[the sun, 2017/03/01 23:31:36]

stdint.h

[tommi, 2017/03/02 14:11:59]

removed now

+
 #include "webrtc/base/atomicops.h"
 #include "webrtc/base/checks.h"
+#include "webrtc/base/timeutils.h"
 
 #if defined(WEBRTC_LINUX)
 #include <sys/prctl.h>
 #include <sys/syscall.h>
 #endif
 
 namespace rtc {
 
 PlatformThreadId CurrentThreadId() {
   PlatformThreadId ret;
@@ skipping 188 matching lines @@
 void PlatformThread::Run() {
   // Attach the worker thread checker to this thread.
   RTC_DCHECK(spawned_thread_checker_.CalledOnValidThread());
   rtc::SetCurrentThreadName(name_.c_str());
 
   if (run_function_) {
     SetPriority(priority_);
     run_function_(obj_);
     return;
   }
-// TODO(tommi): Delete the below.
-#if !defined(WEBRTC_MAC) && !defined(WEBRTC_WIN)
-  const struct timespec ts_null = {0};
+
+  // TODO(tommi): Delete the rest of this function when looping isn't supported.
+#if RTC_DCHECK_IS_ON
+  static const int kMaxLoopCount = 1000;
+  static const int kPeriodToMeasureMs = 100;
+  int64_t loop_stamps[kMaxLoopCount] = {};
+  int64_t sequence_nr = 0;
 #endif
+
   do {
     // The interface contract of Start/Stop is that for a successful call to
     // Start, there should be at least one call to the run function.  So we
     // call the function before checking |stop_|.
     if (!run_function_deprecated_(obj_))
       break;
+#if RTC_DCHECK_IS_ON

[the sun, 2017/03/01 23:31:36]

A comment wouldn't hurt, considering the above constants are empirical. E.g.
// We consider threads iterating more often than 100ms to be "busy", but only
after 1000 iterations.

[tommi, 2017/03/02 14:11:59]

Done.

+    auto id = sequence_nr % kMaxLoopCount;
+    loop_stamps[id] = rtc::TimeMillis();
+    if (sequence_nr > kMaxLoopCount) {
+      auto compare_id = (id + 1) % kMaxLoopCount;
+      auto diff = loop_stamps[id] - loop_stamps[compare_id];

[the sun, 2017/03/01 23:31:36]

Why do you store the whole sequence, when you're only comparing against the last
time stamp?

[tommi, 2017/03/02 14:11:59]

Since this is a sliding window, the last time stamp is kMaxLoopCount-1 stamps
away, so we need to know all the stamps.  We compare against all of them, but
only one of them at a time.

[the sun, 2017/03/02 14:20:09]

Ah, got the indices wrong - thanks for explaining.

+      RTC_DCHECK_GE(diff, 0);
+      if (diff < kPeriodToMeasureMs) {
+        RTC_NOTREACHED() << "This thread is too busy: " << name_ << " " << diff
+          << "ms sequence=" << sequence_nr << " " << loop_stamps[id] << " vs "
+          << loop_stamps[compare_id] << ", " << id << " vs " << compare_id;
+      }
+    }
+    ++sequence_nr;
+#endif
 #if defined(WEBRTC_WIN)
     // Alertable sleep to permit RaiseFlag to run and update |stop_|.
     SleepEx(0, true);
   } while (!stop_);
 #else
-#if defined(WEBRTC_MAC)
     sched_yield();
-#else
-    nanosleep(&ts_null, nullptr);
-#endif
   } while (!AtomicOps::AcquireLoad(&stop_flag_));
 #endif  // defined(WEBRTC_WIN)
 }
 
 bool PlatformThread::SetPriority(ThreadPriority priority) {
 #if RTC_DCHECK_IS_ON
   if (run_function_) {
     // The non-deprecated way of how this function gets called, is that it must
     // be called on the worker thread itself.
     RTC_DCHECK(spawned_thread_checker_.CalledOnValidThread());
@@ skipping 59 matching lines @@
 #if defined(WEBRTC_WIN)
 bool PlatformThread::QueueAPC(PAPCFUNC function, ULONG_PTR data) {
   RTC_DCHECK(thread_checker_.CalledOnValidThread());
   RTC_DCHECK(IsRunning());
 
   return QueueUserAPC(function, thread_, data) != FALSE;
 }
 #endif
 
 }  // namespace rtc