Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2719553002:
Roll breakpad 37070c5..eaedc45 (Closed)
DescriptionRoll breakpad 37070c5..eaedc45
eaedc45 Improve stack sanitization unittests.
0ca6751 Handle ntdll only emitting PUBLIC at func entry
c7e826f Make stack sanitization elide pointers to non-executable mappings.
918f3dc Use the correct PC when determining whether to skip storing a stack.
f9d3ab8 minidump: mark Read as override in derived classes
3ff7ca4 Fix compile errors arising from compiling breakpad with clang.
3996c1b libdisasm: add upstream/license details
603f8b6 There is no need to use the main queue just for perform selector.
e6123b1 Appveyor CI for Windows MSVS build
376784d processor: drop set-but-unused variable
122d65d macho_reader_unittest: use EXPECT_FALSE
093fab2 windows: fix build on pre-Win10 systems
620e0fb windows: update gtest/gmock paths
fc92bb3 fix write() unused-result warning
d5f233d Fixed leak of unloaded module lists.
symupload.exe was built by generating a vsproj using gyp, and building a
Release build in VS 2015.
R=thestig@chromium.org
BUG=678874
Review-Url: https://codereview.chromium.org/2719553002
Cr-Commit-Position: refs/heads/master@{#452979}
Committed: https://chromium.googlesource.com/chromium/src/+/12a3f61803fefb0aeb06f3f4093ea8b06a29fbb3
Patch Set 1 #Patch Set 2 : . #Messages
Total messages: 24 (16 generated)
Description was changed from ========== Roll breakpad 37070c5e6..0ca67517e 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. symupload.exe was built by generating vsproj and building a Release build in VS 2015. R=thestig@chromium.org,tobiasjs@google.com,vapier@chromium.org,georgekola@goo... ========== to ========== Roll breakpad 37070c5e6..0ca67517e 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. symupload.exe was built by generating vsproj and building a Release build in VS 2015. R=thestig@chromium.org,tobiasjs@google.com,vapier@chromium.org,georgekola@goo... ==========
scottmg@chromium.org changed reviewers: - georgekola@google.com, jperaza@chromium.org, tobiasjs@google.com, vapier@chromium.org
Description was changed from ========== Roll breakpad 37070c5e6..0ca67517e 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. symupload.exe was built by generating vsproj and building a Release build in VS 2015. R=thestig@chromium.org,tobiasjs@google.com,vapier@chromium.org,georgekola@goo... ========== to ========== Roll breakpad 37070c5e6..0ca67517e 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. symupload.exe was built by generating vsproj and building a Release build in VS 2015. R=thestig@chromium.org BUG=678874 ==========
Description was changed from ========== Roll breakpad 37070c5e6..0ca67517e 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. symupload.exe was built by generating vsproj and building a Release build in VS 2015. R=thestig@chromium.org BUG=678874 ========== to ========== Roll breakpad 37070c5e6..0ca67517e 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. symupload.exe was built by generating a vsproj using gyp, and building a Release build in VS 2015. R=thestig@chromium.org BUG=678874 ==========
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Sorry, this isn't going to pass the trybots until https://chromium-review.googlesource.com/c/446108/ lands. :(
On 2017/02/24 17:49:27, Tobias Sargeant wrote: > Sorry, this isn't going to pass the trybots until > https://chromium-review.googlesource.com/c/446108/ lands. :( Landed.
Description was changed from ========== Roll breakpad 37070c5e6..0ca67517e 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. symupload.exe was built by generating a vsproj using gyp, and building a Release build in VS 2015. R=thestig@chromium.org BUG=678874 ========== to ========== Roll breakpad 37070c5..eaedc45 eaedc45 Improve stack sanitization unittests. 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. symupload.exe was built by generating a vsproj using gyp, and building a Release build in VS 2015. R=thestig@chromium.org BUG=678874 ==========
Description was changed from ========== Roll breakpad 37070c5..eaedc45 eaedc45 Improve stack sanitization unittests. 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. symupload.exe was built by generating a vsproj using gyp, and building a Release build in VS 2015. R=thestig@chromium.org BUG=678874 ========== to ========== Roll breakpad 37070c5..eaedc45 eaedc45 Improve stack sanitization unittests. 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. symupload.exe was built by generating a vsproj using gyp, and building a Release build in VS 2015. R=thestig@chromium.org BUG=678874 ==========
On 2017/02/24 20:01:01, Tobias Sargeant wrote: > On 2017/02/24 17:49:27, Tobias Sargeant wrote: > > Sorry, this isn't going to pass the trybots until > > https://chromium-review.googlesource.com/c/446108/ lands. :( > > Landed. Thanks, updated to pull that in, and I'll see how it goes this time.
The CQ bit was checked by scottmg@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
rs lgtm
The CQ bit was unchecked by scottmg@chromium.org
The CQ bit was checked by scottmg@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487973755365180,
"parent_rev": "4efc08b53165c7cca522a5d0fcbd5639281f4906", "commit_rev":
"12a3f61803fefb0aeb06f3f4093ea8b06a29fbb3"}
Message was sent while issue was closed.
Description was changed from ========== Roll breakpad 37070c5..eaedc45 eaedc45 Improve stack sanitization unittests. 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. symupload.exe was built by generating a vsproj using gyp, and building a Release build in VS 2015. R=thestig@chromium.org BUG=678874 ========== to ========== Roll breakpad 37070c5..eaedc45 eaedc45 Improve stack sanitization unittests. 0ca6751 Handle ntdll only emitting PUBLIC at func entry c7e826f Make stack sanitization elide pointers to non-executable mappings. 918f3dc Use the correct PC when determining whether to skip storing a stack. f9d3ab8 minidump: mark Read as override in derived classes 3ff7ca4 Fix compile errors arising from compiling breakpad with clang. 3996c1b libdisasm: add upstream/license details 603f8b6 There is no need to use the main queue just for perform selector. e6123b1 Appveyor CI for Windows MSVS build 376784d processor: drop set-but-unused variable 122d65d macho_reader_unittest: use EXPECT_FALSE 093fab2 windows: fix build on pre-Win10 systems 620e0fb windows: update gtest/gmock paths fc92bb3 fix write() unused-result warning d5f233d Fixed leak of unloaded module lists. symupload.exe was built by generating a vsproj using gyp, and building a Release build in VS 2015. R=thestig@chromium.org BUG=678874 Review-Url: https://codereview.chromium.org/2719553002 Cr-Commit-Position: refs/heads/master@{#452979} Committed: https://chromium.googlesource.com/chromium/src/+/12a3f61803fefb0aeb06f3f4093e... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/12a3f61803fefb0aeb06f3f4093e...
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2719703004/ by scottmg@chromium.org. The reason for reverting is: Likely causing crbug.com/696257.. |
