webrtc/pc/rtcstats_integrationtest.cc - Issue 2719523002: RTCIceCandidatePairStats.[total/current]RoundTripTime collected.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/pc/rtcstats_integrationtest.cc

Issue 2719523002: RTCIceCandidatePairStats.[total/current]RoundTripTime collected. (Closed)

Patch Set: Non-optional total RTT, SendPingAndReceiveResponse with ScopedFakeClock Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/pc/rtcstats_integrationtest.cc

diff --git a/webrtc/pc/rtcstats_integrationtest.cc b/webrtc/pc/rtcstats_integrationtest.cc

index 25b31f7dd743da4cec30669e906a79a7c5f8cc73..6ca7be743d79f455dcdd42d3042248995af49998 100644

--- a/webrtc/pc/rtcstats_integrationtest.cc

+++ b/webrtc/pc/rtcstats_integrationtest.cc

@@ -372,7 +372,8 @@ class RTCStatsReportVerifier {

verifier.TestMemberIsUndefined(candidate_pair.readable);

verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.bytes_sent);

verifier.TestMemberIsNonNegative<uint64_t>(candidate_pair.bytes_received);

- verifier.TestMemberIsUndefined(candidate_pair.total_round_trip_time);

+ verifier.TestMemberIsNonNegative<double>(

+ candidate_pair.total_round_trip_time);

verifier.TestMemberIsNonNegative<double>(

candidate_pair.current_round_trip_time);

if (is_selected_pair) {