Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: webrtc/base/proxyserver.cc

Issue 2718663005: Replace NULL with nullptr or null in webrtc/base/. (Closed)
Patch Set: Fixing Windows and formatting issues. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/base/proxy_unittest.cc ('k') | webrtc/base/scoped_autorelease_pool.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2004 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2004 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
11 #include "webrtc/base/proxyserver.h" 11 #include "webrtc/base/proxyserver.h"
12 12
13 #include <algorithm> 13 #include <algorithm>
14 14
15 #include "webrtc/base/checks.h" 15 #include "webrtc/base/checks.h"
16 #include "webrtc/base/socketfactory.h" 16 #include "webrtc/base/socketfactory.h"
17 17
18 namespace rtc { 18 namespace rtc {
19 19
20 // ProxyServer 20 // ProxyServer
21 ProxyServer::ProxyServer( 21 ProxyServer::ProxyServer(
22 SocketFactory* int_factory, const SocketAddress& int_addr, 22 SocketFactory* int_factory, const SocketAddress& int_addr,
23 SocketFactory* ext_factory, const SocketAddress& ext_ip) 23 SocketFactory* ext_factory, const SocketAddress& ext_ip)
24 : ext_factory_(ext_factory), ext_ip_(ext_ip.ipaddr(), 0), // strip off port 24 : ext_factory_(ext_factory), ext_ip_(ext_ip.ipaddr(), 0), // strip off port
25 server_socket_(int_factory->CreateAsyncSocket(int_addr.family(), 25 server_socket_(int_factory->CreateAsyncSocket(int_addr.family(),
26 SOCK_STREAM)) { 26 SOCK_STREAM)) {
27 RTC_DCHECK(server_socket_.get() != NULL); 27 RTC_DCHECK(server_socket_.get() != nullptr);
28 RTC_DCHECK(int_addr.family() == AF_INET || int_addr.family() == AF_INET6); 28 RTC_DCHECK(int_addr.family() == AF_INET || int_addr.family() == AF_INET6);
29 server_socket_->Bind(int_addr); 29 server_socket_->Bind(int_addr);
30 server_socket_->Listen(5); 30 server_socket_->Listen(5);
31 server_socket_->SignalReadEvent.connect(this, &ProxyServer::OnAcceptEvent); 31 server_socket_->SignalReadEvent.connect(this, &ProxyServer::OnAcceptEvent);
32 } 32 }
33 33
34 ProxyServer::~ProxyServer() { 34 ProxyServer::~ProxyServer() {
35 for (BindingList::iterator it = bindings_.begin(); 35 for (BindingList::iterator it = bindings_.begin();
36 it != bindings_.end(); ++it) { 36 it != bindings_.end(); ++it) {
37 delete (*it); 37 delete (*it);
38 } 38 }
39 } 39 }
40 40
41 SocketAddress ProxyServer::GetServerAddress() { 41 SocketAddress ProxyServer::GetServerAddress() {
42 return server_socket_->GetLocalAddress(); 42 return server_socket_->GetLocalAddress();
43 } 43 }
44 44
45 void ProxyServer::OnAcceptEvent(AsyncSocket* socket) { 45 void ProxyServer::OnAcceptEvent(AsyncSocket* socket) {
46 RTC_DCHECK(socket != NULL && socket == server_socket_.get()); 46 RTC_DCHECK(socket != nullptr && socket == server_socket_.get());
47 AsyncSocket* int_socket = socket->Accept(NULL); 47 AsyncSocket* int_socket = socket->Accept(nullptr);
48 AsyncProxyServerSocket* wrapped_socket = WrapSocket(int_socket); 48 AsyncProxyServerSocket* wrapped_socket = WrapSocket(int_socket);
49 AsyncSocket* ext_socket = ext_factory_->CreateAsyncSocket(ext_ip_.family(), 49 AsyncSocket* ext_socket = ext_factory_->CreateAsyncSocket(ext_ip_.family(),
50 SOCK_STREAM); 50 SOCK_STREAM);
51 if (ext_socket) { 51 if (ext_socket) {
52 ext_socket->Bind(ext_ip_); 52 ext_socket->Bind(ext_ip_);
53 bindings_.push_back(new ProxyBinding(wrapped_socket, ext_socket)); 53 bindings_.push_back(new ProxyBinding(wrapped_socket, ext_socket));
54 } else { 54 } else {
55 LOG(LS_ERROR) << "Unable to create external socket on proxy accept event"; 55 LOG(LS_ERROR) << "Unable to create external socket on proxy accept event";
56 } 56 }
57 } 57 }
(...skipping 19 matching lines...) Expand all
77 &ProxyBinding::OnExternalConnect); 77 &ProxyBinding::OnExternalConnect);
78 ext_socket_->SignalReadEvent.connect(this, &ProxyBinding::OnExternalRead); 78 ext_socket_->SignalReadEvent.connect(this, &ProxyBinding::OnExternalRead);
79 ext_socket_->SignalWriteEvent.connect(this, &ProxyBinding::OnExternalWrite); 79 ext_socket_->SignalWriteEvent.connect(this, &ProxyBinding::OnExternalWrite);
80 ext_socket_->SignalCloseEvent.connect(this, &ProxyBinding::OnExternalClose); 80 ext_socket_->SignalCloseEvent.connect(this, &ProxyBinding::OnExternalClose);
81 } 81 }
82 82
83 ProxyBinding::~ProxyBinding() = default; 83 ProxyBinding::~ProxyBinding() = default;
84 84
85 void ProxyBinding::OnConnectRequest(AsyncProxyServerSocket* socket, 85 void ProxyBinding::OnConnectRequest(AsyncProxyServerSocket* socket,
86 const SocketAddress& addr) { 86 const SocketAddress& addr) {
87 RTC_DCHECK(!connected_ && ext_socket_.get() != NULL); 87 RTC_DCHECK(!connected_ && ext_socket_.get() != nullptr);
88 ext_socket_->Connect(addr); 88 ext_socket_->Connect(addr);
89 // TODO: handle errors here 89 // TODO: handle errors here
90 } 90 }
91 91
92 void ProxyBinding::OnInternalRead(AsyncSocket* socket) { 92 void ProxyBinding::OnInternalRead(AsyncSocket* socket) {
93 Read(int_socket_.get(), &out_buffer_); 93 Read(int_socket_.get(), &out_buffer_);
94 Write(ext_socket_.get(), &out_buffer_); 94 Write(ext_socket_.get(), &out_buffer_);
95 } 95 }
96 96
97 void ProxyBinding::OnInternalWrite(AsyncSocket* socket) { 97 void ProxyBinding::OnInternalWrite(AsyncSocket* socket) {
98 Write(int_socket_.get(), &in_buffer_); 98 Write(int_socket_.get(), &in_buffer_);
99 } 99 }
100 100
101 void ProxyBinding::OnInternalClose(AsyncSocket* socket, int err) { 101 void ProxyBinding::OnInternalClose(AsyncSocket* socket, int err) {
102 Destroy(); 102 Destroy();
103 } 103 }
104 104
105 void ProxyBinding::OnExternalConnect(AsyncSocket* socket) { 105 void ProxyBinding::OnExternalConnect(AsyncSocket* socket) {
106 RTC_DCHECK(socket != NULL); 106 RTC_DCHECK(socket != nullptr);
107 connected_ = true; 107 connected_ = true;
108 int_socket_->SendConnectResult(0, socket->GetRemoteAddress()); 108 int_socket_->SendConnectResult(0, socket->GetRemoteAddress());
109 } 109 }
110 110
111 void ProxyBinding::OnExternalRead(AsyncSocket* socket) { 111 void ProxyBinding::OnExternalRead(AsyncSocket* socket) {
112 Read(ext_socket_.get(), &in_buffer_); 112 Read(ext_socket_.get(), &in_buffer_);
113 Write(int_socket_.get(), &in_buffer_); 113 Write(int_socket_.get(), &in_buffer_);
114 } 114 }
115 115
116 void ProxyBinding::OnExternalWrite(AsyncSocket* socket) { 116 void ProxyBinding::OnExternalWrite(AsyncSocket* socket) {
117 Write(ext_socket_.get(), &out_buffer_); 117 Write(ext_socket_.get(), &out_buffer_);
118 } 118 }
119 119
120 void ProxyBinding::OnExternalClose(AsyncSocket* socket, int err) { 120 void ProxyBinding::OnExternalClose(AsyncSocket* socket, int err) {
121 if (!connected_) { 121 if (!connected_) {
122 int_socket_->SendConnectResult(err, SocketAddress()); 122 int_socket_->SendConnectResult(err, SocketAddress());
123 } 123 }
124 Destroy(); 124 Destroy();
125 } 125 }
126 126
127 void ProxyBinding::Read(AsyncSocket* socket, FifoBuffer* buffer) { 127 void ProxyBinding::Read(AsyncSocket* socket, FifoBuffer* buffer) {
128 // Only read if the buffer is empty. 128 // Only read if the buffer is empty.
129 RTC_DCHECK(socket != NULL); 129 RTC_DCHECK(socket != nullptr);
130 size_t size; 130 size_t size;
131 int read; 131 int read;
132 if (buffer->GetBuffered(&size) && size == 0) { 132 if (buffer->GetBuffered(&size) && size == 0) {
133 void* p = buffer->GetWriteBuffer(&size); 133 void* p = buffer->GetWriteBuffer(&size);
134 read = socket->Recv(p, size, nullptr); 134 read = socket->Recv(p, size, nullptr);
135 buffer->ConsumeWriteBuffer(std::max(read, 0)); 135 buffer->ConsumeWriteBuffer(std::max(read, 0));
136 } 136 }
137 } 137 }
138 138
139 void ProxyBinding::Write(AsyncSocket* socket, FifoBuffer* buffer) { 139 void ProxyBinding::Write(AsyncSocket* socket, FifoBuffer* buffer) {
140 RTC_DCHECK(socket != NULL); 140 RTC_DCHECK(socket != nullptr);
141 size_t size; 141 size_t size;
142 int written; 142 int written;
143 const void* p = buffer->GetReadData(&size); 143 const void* p = buffer->GetReadData(&size);
144 written = socket->Send(p, size); 144 written = socket->Send(p, size);
145 buffer->ConsumeReadData(std::max(written, 0)); 145 buffer->ConsumeReadData(std::max(written, 0));
146 } 146 }
147 147
148 void ProxyBinding::Destroy() { 148 void ProxyBinding::Destroy() {
149 SignalDestroyed(this); 149 SignalDestroyed(this);
150 } 150 }
151 151
152 AsyncProxyServerSocket* SocksProxyServer::WrapSocket(AsyncSocket* socket) { 152 AsyncProxyServerSocket* SocksProxyServer::WrapSocket(AsyncSocket* socket) {
153 return new AsyncSocksProxyServerSocket(socket); 153 return new AsyncSocksProxyServerSocket(socket);
154 } 154 }
155 155
156 } // namespace rtc 156 } // namespace rtc
OLDNEW
« no previous file with comments | « webrtc/base/proxy_unittest.cc ('k') | webrtc/base/scoped_autorelease_pool.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698