webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc - Issue 2717973005: Test field trial group with startswith rather than equals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc

Issue 2717973005: Test field trial group with startswith rather than equals. (Closed)

Patch Set: Added IsEnabled() convenience function Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/media/engine/webrtcvoiceengine.cc ('k') | webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc » ('j') | webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc b/webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc

index df0b470116b72f414a6bc3be1a7e4df86caf008d..04f8575223db68df1ef5293c37aaf3e795bd9a52 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/bitrate_controller.cc

@@ -51,8 +51,10 @@ void BitrateController::MakeDecision(

// Current implementation of BitrateController can only work when

// |metrics.target_audio_bitrate_bps| includes overhead is enabled. This is

// currently governed by the following field trial.

- RTC_DCHECK_EQ("Enabled", webrtc::field_trial::FindFullName(

- "WebRTC-SendSideBwe-WithOverhead"));

+ RTC_DCHECK_EQ(

+ 0,

+ webrtc::field_trial::FindFullName("WebRTC-SendSideBwe-WithOverhead")

+ .find("Enabled"));

tommi 2017/02/28 11:52:41 RTC_DCHECK(webrtc::field_trial::IsEnabled("WebRTC-

sprang_webrtc 2017/02/28 12:18:31 Done.

if (config->frame_length_ms)

frame_length_ms_ = *config->frame_length_ms;

int overhead_rate_bps =