webrtc/p2p/client/basicportallocator.cc - Issue 2717893003: Making candidate pool size behave as decided in JSEP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/p2p/client/basicportallocator.cc

Issue 2717893003: Making candidate pool size behave as decided in JSEP. (Closed)

Patch Set: Get rid of now-unnecessary test. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/p2p/client/basicportallocator.cc

diff --git a/webrtc/p2p/client/basicportallocator.cc b/webrtc/p2p/client/basicportallocator.cc

index 629218f89a3e1baee6c81a5e0dbce7820218d564..64469f91093658933bbd25828b8173ab9217d289 100644

--- a/webrtc/p2p/client/basicportallocator.cc

+++ b/webrtc/p2p/client/basicportallocator.cc

@@ -169,6 +169,9 @@ void BasicPortAllocator::OnIceRegathering(PortAllocatorSession* session,

}

BasicPortAllocator::~BasicPortAllocator() {

+ // Our created port allocator sessions depend on us, so destroy our remaining

+ // pooled sessions before anything else.

+ DiscardPooledSessions();

}

PortAllocatorSession* BasicPortAllocator::CreateSessionInternal(