webrtc/modules/audio_processing/aec3/echo_canceller3.cc - Issue 2717353002: Further tuning for AEC3 for initial echo suppression and handling of echo path changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_processing/aec3/echo_canceller3.cc

Issue 2717353002: Further tuning for AEC3 for initial echo suppression and handling of echo path changes (Closed)

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/audio_processing/aec3/echo_canceller3.cc

diff --git a/webrtc/modules/audio_processing/aec3/echo_canceller3.cc b/webrtc/modules/audio_processing/aec3/echo_canceller3.cc

index 60efced0ecaf96ce9534ed8b963fe7e11d0896d7..ed12a4799535155b60e237a7082a0b4f184c2b03 100644

--- a/webrtc/modules/audio_processing/aec3/echo_canceller3.cc

+++ b/webrtc/modules/audio_processing/aec3/echo_canceller3.cc

@@ -260,7 +260,7 @@ bool EchoCanceller3::AnalyzeRender(AudioBuffer* render) {

void EchoCanceller3::AnalyzeCapture(AudioBuffer* capture) {

RTC_DCHECK_RUNS_SERIALIZED(&capture_race_checker_);

RTC_DCHECK(capture);

- data_dumper_->DumpWav("aec3_capture_analyze_input", frame_length_,

+ data_dumper_->DumpWav("aec3_capture_analyze_input", capture->num_frames(),

peah-webrtc 2017/02/27 14:26:03 The framelength was wrong here before.

capture->channels_f()[0], sample_rate_hz_, 1);

saturated_microphone_signal_ = false;