Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Unified Diff: webrtc/common_audio/BUILD.gn

Issue 2717123004: Avoid overflow in WebRtcSpl_DotProductWithScale (Closed)
Patch Set: Move to separate target Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/common_audio/BUILD.gn
diff --git a/webrtc/common_audio/BUILD.gn b/webrtc/common_audio/BUILD.gn
index a3cf046bb46ddb4dcdb655e7e3d83ef6c305d522..52a6e2e05f5ef9e7062e97322923a453c651f3d2 100644
--- a/webrtc/common_audio/BUILD.gn
+++ b/webrtc/common_audio/BUILD.gn
@@ -113,7 +113,6 @@ rtc_source_set("common_audio_c") {
"signal_processing/copy_set_operations.c",
"signal_processing/cross_correlation.c",
"signal_processing/division_operations.c",
- "signal_processing/dot_product_with_scale.c",
"signal_processing/downsample_fast.c",
"signal_processing/energy.c",
"signal_processing/filter_ar.c",
@@ -198,6 +197,24 @@ rtc_source_set("common_audio_c") {
cflags = [ "/wd4334" ] # Ignore warning on shift operator promotion.
}
+ deps = [
+ ":common_audio_cc",
+ ]
+
+ public_configs = [ ":common_audio_config" ]
+}
+
+rtc_source_set("common_audio_cc") {
+ visibility = [ ":*" ] # Only targets in this file can depend on this.
+ sources = [
+ "signal_processing/dot_product_with_scale.cc",
+ "signal_processing/dot_product_with_scale.h",
+ ]
+
+ if (is_win) {
+ cflags = [ "/wd4334" ] # Ignore warning on shift operator promotion.
kwiberg-webrtc 2017/02/28 12:51:01 This looks like an easy warning to just fix in thi
+ }
+
public_configs = [ ":common_audio_config" ]
}

Powered by Google App Engine
This is Rietveld 408576698