Enable GN check for webrtc/base

webrtc/base/BUILD.gn

Index: webrtc/base/BUILD.gn
diff --git a/webrtc/base/BUILD.gn b/webrtc/base/BUILD.gn
index d81720652ce6b6db9d915ffc192a6203ff2d70b7..71d8c529b7b5e5fe0de86da8373681b3712a90e0 100644
--- a/webrtc/base/BUILD.gn
+++ b/webrtc/base/BUILD.gn
@@ -81,6 +81,11 @@ if (!rtc_build_ssl) {
 
 # The subset of rtc_base approved for use outside of libjingle.
 rtc_static_library("rtc_base_approved") {
+  # TODO(kjellander): Remove (bugs.webrtc.org/6828)
+  # Enabling GN check triggers two cyclic dependency errors:
+  #   :rtc_base_approved -> :rtc_base -> :rtc_base_approved

[tommi, 2017/03/31 08:38:29]

where is the dependency from base_approved to base?

[kjellander_webrtc, 2017/04/04 04:23:09]

ERROR at //webrtc/base/md5digest.h:15:11: Include not allowed.
#include "webrtc/base/messagedigest.h"
          ^--------------------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc/base:rtc_base
which should somehow be reachable.
___________________
ERROR at //webrtc/base/pathutils.cc:19:11: Include not allowed.
#include "webrtc/base/fileutils.h"
          ^----------------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc/base:rtc_base
which should somehow be reachable.


The first one can easily be fixed by moving messagedigest.h to
rtc_base_approved. But the second one requires more work (it was sneaked in
here:
https://codereview.webrtc.org/2533213005/diff/120001/webrtc/base/BUILD.gn).

Also there are two violations causing a cycle with system_wrappers as well:

ERROR at //webrtc/base/location.h:16:11: Include not allowed.
#include "webrtc/system_wrappers/include/stringize_macros.h"
          ^------------------------------------------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc/system_wrappers:system_wrappers
which should somehow be reachable.
___________________
ERROR at //webrtc/base/rate_limiter.cc:12:11: Include not allowed.
#include "webrtc/system_wrappers/include/clock.h"
          ^-------------------------------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc/system_wrappers:system_wrappers
which should somehow be reachable.

[tommi, 2017/04/04 09:53:14]

md5digest.h should not be in rtc_base_approved.  It's used only in some audio
tests, so I'd rather not hack rtc_base_approved for this.
I think this include can simply be removed.
Can you take a look at those places and see if they really make sense?

[kjellander_webrtc, 2017/04/10 12:54:02]

You're right that it's only used for audio tests. What's your advice on what to
do with md5digest.* then? Move to webrtc/test instead?
Correct, that was easy!
https://cs.chromium.org/chromium/src/third_party/webrtc/system_wrappers/inclu...
is simple to move into webrtc/base instead. Should I just incorporate it in
rtc_base_approved?
It seems borrowed straight of from Chromium's base.
To solve this one, I think we'd have to move clock.h, ntp_time.h and
rw_lock_wrapper.h into rtc_base_approved.
See above.

+  #   :rtc_base_approved -> //webrtc/system_wrappers -> :rtc_base_approved
+  check_includes = false
   defines = []
   libs = []
   deps = []
@@ -271,6 +276,7 @@ rtc_static_library("rtc_base_approved") {
       }
     }
   }
+  deps += [ "..:webrtc_common" ]

[tommi, 2017/03/08 13:36:45]

base_approved shouldn't have any dependencies like this. a dependency should be
the other way.

[kjellander_webrtc, 2017/03/08 13:56:04]

Well, what I'm doing here is just adding what is actually used in the sources.
webrtc_common is a tiny target only containing a few headers, but I'm open to
merging it into rtc_base_approved (but not in this CL). If I remove this and the
check_includes = false line at line 88 I get these errors:

ERROR at //webrtc/base/checks.h:14:11: Include not allowed.
#include "webrtc/typedefs.h"
          ^----------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc:webrtc_common
which should somehow be reachable.
___________________
ERROR at //webrtc/base/format_macros.h:27:11: Include not allowed.
#include "webrtc/typedefs.h"
          ^----------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc:webrtc_common
which should somehow be reachable.
___________________
ERROR at //webrtc/base/location.h:16:11: Include not allowed.
#include "webrtc/system_wrappers/include/stringize_macros.h"
          ^------------------------------------------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc/system_wrappers:system_wrappers
which should somehow be reachable.
___________________
ERROR at //webrtc/base/md5digest.h:15:11: Include not allowed.
#include "webrtc/base/messagedigest.h"
          ^--------------------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc/base:rtc_base
which should somehow be reachable.
___________________
ERROR at //webrtc/base/onetimeevent.h:15:11: Include not allowed.
#include "webrtc/typedefs.h"
          ^----------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc:webrtc_common
which should somehow be reachable.
___________________
ERROR at //webrtc/base/pathutils.cc:19:11: Include not allowed.
#include "webrtc/base/fileutils.h"
          ^----------------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc/base:rtc_base
which should somehow be reachable.
___________________
ERROR at //webrtc/base/random.h:16:11: Include not allowed.
#include "webrtc/typedefs.h"
          ^----------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc:webrtc_common
which should somehow be reachable.
___________________
ERROR at //webrtc/base/rate_limiter.cc:12:11: Include not allowed.
#include "webrtc/system_wrappers/include/clock.h"
          ^-------------------------------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc/system_wrappers:system_wrappers
which should somehow be reachable.
___________________
ERROR at //webrtc/base/rate_statistics.h:17:11: Include not allowed.
#include "webrtc/typedefs.h"
          ^----------------
It is not in any dependency of
  //webrtc/base:rtc_base_approved
The include file is in the target(s):
  //webrtc:webrtc_common
which should somehow be reachable.

[tommi, 2017/03/31 08:38:29]

Ack. Is there information about this in the bug? (or is this another bug?)

[kjellander_webrtc, 2017/04/04 04:23:09]

The referenced bug only deals with the enabling of GN check. Cleaning this up
should be done separately (I'm not aware of any specific bug for webrtc_common
and I'm not one is needed unless you're suggesting we merge those headers into
rtc_base_approved).

 }
 
 config("enable_libevent_config") {
@@ -359,6 +365,10 @@ rtc_static_library("rtc_task_runner") {
     "taskrunner.cc",
     "taskrunner.h",
   ]
+  deps = [
+    ":rtc_base",
+    ":rtc_base_approved",
+  ]
 }
 
 rtc_static_library("rtc_base") {
@@ -663,7 +673,11 @@ if (rtc_include_tests) {
     ]
     public_configs = [ ":rtc_base_tests_utils_exported_config" ]
     deps = [
+      ":rtc_base",
+      ":rtc_base_approved",
       ":rtc_base_tests_utils",
+      "../test:field_trial",
+      "../test:test_support",
     ]
     public_deps = [
       "//testing/gmock",
@@ -740,6 +754,9 @@ if (rtc_include_tests) {
     deps = [
       ":rtc_base",
       ":rtc_base_tests_main",
+      ":rtc_base_tests_utils",
+      "../system_wrappers:system_wrappers",
+      "../test:test_support",
       "//testing/gtest",
     ]
     if (is_win) {
@@ -793,8 +810,13 @@ if (rtc_include_tests) {
       "timeutils_unittest.cc",
     ]
     deps = [
+      ":rtc_base",
       ":rtc_base_approved",
       ":rtc_base_tests_main",
+      ":rtc_base_tests_utils",
+      ":rtc_task_queue",
+      "../system_wrappers:system_wrappers",
+      "../test:test_support",
     ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
@@ -811,7 +833,9 @@ if (rtc_include_tests) {
     ]
     deps = [
       ":rtc_base_tests_main",
+      ":rtc_base_tests_utils",
       ":rtc_task_queue",
+      "../test:test_support",
     ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
@@ -826,8 +850,10 @@ if (rtc_include_tests) {
       "numerics/percentile_filter_unittest.cc",
     ]
     deps = [
+      ":rtc_base_approved",
       ":rtc_base_tests_main",
       ":rtc_numerics",
+      "../test:test_support",
     ]
   }
 
@@ -883,6 +909,7 @@ if (rtc_include_tests) {
     }
     deps = [
       ":rtc_base_tests_main",
+      ":rtc_base_tests_utils",
       ":rtc_task_runner",
     ]
     public_deps = [