Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: .gn

Issue 2717083002: Enable GN check for webrtc/base (Closed)
Patch Set: Rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/base/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/dotfile_settings.gni") 9 import("//build/dotfile_settings.gni")
10 10
11 # The location of the build configuration file. 11 # The location of the build configuration file.
12 buildconfig = "//build/config/BUILDCONFIG.gn" 12 buildconfig = "//build/config/BUILDCONFIG.gn"
13 13
14 # The secondary source root is a parallel directory tree where 14 # The secondary source root is a parallel directory tree where
15 # GN build files are placed when they can not be placed directly 15 # GN build files are placed when they can not be placed directly
16 # in the source tree, e.g. for third party source trees. 16 # in the source tree, e.g. for third party source trees.
17 secondary_source = "//build/secondary/" 17 secondary_source = "//build/secondary/"
18 18
19 # These are the targets to check headers for by default. The files in targets 19 # These are the targets to check headers for by default. The files in targets
20 # matching these patterns (see "gn help label_pattern" for format) will have 20 # matching these patterns (see "gn help label_pattern" for format) will have
21 # their includes checked for proper dependencies when you run either 21 # their includes checked for proper dependencies when you run either
22 # "gn check" or "gn gen --check". 22 # "gn check" or "gn gen --check".
23 # TODO(kjellander): Keep adding paths to this list as work in webrtc:5589 is don e. 23 # TODO(kjellander): Keep adding paths to this list as work in webrtc:5589 is don e.
24 check_targets = [ 24 check_targets = [
25 "//webrtc/api/*", 25 "//webrtc/api/*",
26 "//webrtc/audio/*", 26 "//webrtc/audio/*",
27 "//webrtc/base/*",
27 "//webrtc/call/*", 28 "//webrtc/call/*",
28 "//webrtc/common_video/*", 29 "//webrtc/common_video/*",
29 "//webrtc/common_audio/*", 30 "//webrtc/common_audio/*",
30 "//webrtc/examples/*", 31 "//webrtc/examples/*",
31 "//webrtc/logging/*", 32 "//webrtc/logging/*",
32 "//webrtc/media/*", 33 "//webrtc/media/*",
33 "//webrtc/modules/*", 34 "//webrtc/modules/*",
34 "//webrtc/ortc/*", 35 "//webrtc/ortc/*",
35 "//webrtc/stats/*", 36 "//webrtc/stats/*",
36 "//webrtc/tools/*", 37 "//webrtc/tools/*",
37 "//webrtc/test/*", 38 "//webrtc/test/*",
38 "//webrtc/voice_engine/*", 39 "//webrtc/voice_engine/*",
39 ] 40 ]
40 41
41 # These are the list of GN files that run exec_script. This whitelist exists 42 # These are the list of GN files that run exec_script. This whitelist exists
42 # to force additional review for new uses of exec_script, which is strongly 43 # to force additional review for new uses of exec_script, which is strongly
43 # discouraged except for gypi_to_gn calls. 44 # discouraged except for gypi_to_gn calls.
44 exec_script_whitelist = build_dotfile_settings.exec_script_whitelist 45 exec_script_whitelist = build_dotfile_settings.exec_script_whitelist
45 46
46 default_args = { 47 default_args = {
47 # Webrtc does not support component builds because we are not using the 48 # Webrtc does not support component builds because we are not using the
48 # template "component" but we rely directly on "rtc_static_library" and 49 # template "component" but we rely directly on "rtc_static_library" and
49 # "rtc_shared_library". This means that we cannot use the chromium default 50 # "rtc_shared_library". This means that we cannot use the chromium default
50 # value for this argument. 51 # value for this argument.
51 # This also means that the user can override this value using --args or 52 # This also means that the user can override this value using --args or
52 # the args.gn file but this setting will be ignored because we don't support 53 # the args.gn file but this setting will be ignored because we don't support
53 # component builds. 54 # component builds.
54 is_component_build = false 55 is_component_build = false
55 } 56 }
OLDNEW
« no previous file with comments | « no previous file | webrtc/base/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698