Enable GN check for webrtc/base

webrtc/base/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/crypto.gni")
 import("//build/config/ui.gni")
@@ skipping 74 matching lines @@
   ]
   if (rtc_enable_protobuf) {
     public_deps = [
       "//third_party/protobuf:protobuf_lite",
     ]
   }
 }
 
 # The subset of rtc_base approved for use outside of libjingle.
 rtc_static_library("rtc_base_approved") {
+  # TODO(kjellander): Remove (bugs.webrtc.org/7480)
+  # Enabling GN check triggers a cyclic dependency caused by rate_limiter.cc:
+  #   :rtc_base_approved -> //webrtc/system_wrappers -> :rtc_base_approved
+  check_includes = false
   defines = []
   libs = []
   deps = []
   all_dependent_configs = [ ":rtc_base_approved_all_dependent_config" ]
 
   sources = [
     "array_view.h",
     "arraysize.h",
     "atomicops.h",
     "base64.cc",
@@ skipping 24 matching lines @@
     "file.h",
     "flags.cc",
     "flags.h",
     "format_macros.h",
     "function_view.h",
     "ignore_wundef.h",
     "location.cc",
     "location.h",
     "md5.cc",
     "md5.h",
-    "md5digest.cc",
-    "md5digest.h",
     "mod_ops.h",
     "onetimeevent.h",
     "optional.cc",
     "optional.h",
     "pathutils.cc",
     "pathutils.h",
     "platform_file.cc",
     "platform_file.h",
     "platform_thread.cc",
     "platform_thread.h",
@@ skipping 13 matching lines @@
     "refcountedobject.h",
     "safe_compare.h",
     "safe_conversions.h",
     "safe_conversions_impl.h",
     "sanitizer.h",
     "scoped_ref_ptr.h",
     "string_to_number.cc",
     "string_to_number.h",
     "stringencode.cc",
     "stringencode.h",
+    "stringize_macros.h",
     "stringutils.cc",
     "stringutils.h",
     "swap_queue.h",
     "template_util.h",
     "thread_annotations.h",
     "thread_checker.h",
     "thread_checker_impl.cc",
     "thread_checker_impl.h",
     "timestampaligner.cc",
     "timestampaligner.h",
@@ skipping 97 matching lines @@
       if (current_cpu == "x64") {
         data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-x86_64.dll" ]
       } else {
         data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ]
       }
     }
   }
   if (is_nacl) {
     deps += [ "//native_client_sdk/src/libraries/nacl_io" ]
   }
+  deps += [ "..:webrtc_common" ]

[kjellander_webrtc, 2017/04/19 10:58:47]

This is needed by the following files that include webrtc/typedefs.h:
 //webrtc/base/checks.h:14:11
 //webrtc/base/format_macros.h:27:11
 //webrtc/base/onetimeevent.h:15:11
 //webrtc/base/random.h:16:11
 //webrtc/base/rate_limiter.cc:12:11
 //webrtc/base/rate_statistics.h:17:11

[tommi, 2017/04/19 13:45:01]

do we still need this even with checks disabled?

[tommi, 2017/04/19 13:45:01]

Could we instead move typedefs.h to rtc_base_approved?

[kjellander_webrtc, 2017/04/19 13:57:51]

No we can just remove it. I just wanted to add what would be otherwise hidden in
this CL even if not all the work could be done.
Removed in PS#12.

[kjellander_webrtc, 2017/04/19 13:57:51]

We could, but that's a massive amount of work considering how many places it's
included from, I'd rather not do it here.

 }
 
 config("enable_libevent_config") {
   defines = [ "WEBRTC_BUILD_LIBEVENT" ]
 }
 
 rtc_static_library("rtc_task_queue") {
   public_deps = [
     ":rtc_base_approved",
   ]
@@ skipping 362 matching lines @@
     }
   }
 
   rtc_source_set("rtc_base_tests_main") {
     testonly = true
     sources = [
       "unittest_main.cc",
     ]
     public_configs = [ ":rtc_base_tests_utils_exported_config" ]
     deps = [
+      ":rtc_base",
+      ":rtc_base_approved",
       ":rtc_base_tests_utils",
+      "../test:field_trial",
+      "../test:test_support",
     ]
     public_deps = [
       "//testing/gmock",
       "//testing/gtest",
     ]
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 
   rtc_source_set("rtc_base_tests_utils") {
     testonly = true
     sources = [
       # Also use this as a convenient dumping ground for misc files that are
       # included by multiple targets below.
       "cpu_time.cc",
       "cpu_time.h",
       "fakeclock.cc",
       "fakeclock.h",
       "fakenetwork.h",
       "fakesslidentity.h",
       "firewallsocketserver.cc",
       "firewallsocketserver.h",
       "gunit.h",
       "httpserver.cc",
       "httpserver.h",
+      "md5digest.cc",
+      "md5digest.h",
       "memory_usage.cc",
       "memory_usage.h",
       "natserver.cc",
       "natserver.h",
       "natsocketfactory.cc",
       "natsocketfactory.h",
       "nattypes.cc",
       "nattypes.h",
       "proxyserver.cc",
       "proxyserver.h",
@@ skipping 30 matching lines @@
       "nullsocketserver_unittest.cc",
       "physicalsocketserver_unittest.cc",
       "socket_unittest.cc",
       "socket_unittest.h",
       "socketaddress_unittest.cc",
       "virtualsocket_unittest.cc",
     ]
     deps = [
       ":rtc_base",
       ":rtc_base_tests_main",
+      ":rtc_base_tests_utils",
+      "../system_wrappers:system_wrappers",
+      "../test:test_support",
       "//testing/gtest",
     ]
     if (is_win) {
       sources += [ "win32socketserver_unittest.cc" ]
     }
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
@@ skipping 26 matching lines @@
       "pathutils_unittest.cc",
       "platform_thread_unittest.cc",
       "random_unittest.cc",
       "rate_limiter_unittest.cc",
       "rate_statistics_unittest.cc",
       "ratetracker_unittest.cc",
       "refcountedobject_unittest.cc",
       "safe_compare_unittest.cc",
       "string_to_number_unittest.cc",
       "stringencode_unittest.cc",
+      "stringize_macros_unittest.cc",
       "stringutils_unittest.cc",
       "swap_queue_unittest.cc",
       "thread_annotations_unittest.cc",
       "thread_checker_unittest.cc",
       "timestampaligner_unittest.cc",
       "timeutils_unittest.cc",
     ]
     deps = [
+      ":rtc_base",
       ":rtc_base_approved",
       ":rtc_base_tests_main",
+      ":rtc_base_tests_utils",
+      ":rtc_task_queue",
+      "../system_wrappers:system_wrappers",
+      "../test:test_support",
     ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 
   rtc_source_set("rtc_task_queue_unittests") {
     testonly = true
     sources = [
       "sequenced_task_checker_unittest.cc",
       "task_queue_unittest.cc",
       "weak_ptr_unittest.cc",
     ]
     deps = [
       ":rtc_base_tests_main",
+      ":rtc_base_tests_utils",
       ":rtc_task_queue",
+      "../test:test_support",
     ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 
   rtc_source_set("rtc_numerics_unittests") {
     testonly = true
     sources = [
       "numerics/exp_filter_unittest.cc",
       "numerics/percentile_filter_unittest.cc",
     ]
     deps = [
+      ":rtc_base_approved",
       ":rtc_base_tests_main",
       ":rtc_numerics",
+      "../test:test_support",
     ]
   }
 
   config("rtc_base_unittests_config") {
     if (is_clang) {
       cflags = [ "-Wno-unused-const-variable" ]
     }
   }
   rtc_source_set("rtc_base_unittests") {
     testonly = true
@@ skipping 39 matching lines @@
     }
     if (is_posix) {
       sources += [
         "ssladapter_unittest.cc",
         "sslidentity_unittest.cc",
         "sslstreamadapter_unittest.cc",
       ]
     }
     deps = [
       ":rtc_base_tests_main",
+      ":rtc_base_tests_utils",
+      "../test:test_support",
     ]
     public_deps = [
       ":rtc_base",
     ]
     configs += [ ":rtc_base_unittests_config" ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 }
 
 if (is_android) {
   android_library("base_java") {
     java_files = [
       "java/src/org/webrtc/Logging.java",
       "java/src/org/webrtc/Size.java",
       "java/src/org/webrtc/ThreadUtils.java",
     ]
   }
 }