Enable GN check for webrtc/base

webrtc/base/BUILD.gn

 # Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/crypto.gni")
 import("//build/config/ui.gni")
@@ skipping 63 matching lines @@
 if (!rtc_build_ssl) {
   config("external_ssl_library") {
     assert(rtc_ssl_root != "",
            "You must specify rtc_ssl_root when rtc_build_ssl==0.")
     include_dirs = [ rtc_ssl_root ]
   }
 }
 
 # The subset of rtc_base approved for use outside of libjingle.
 rtc_static_library("rtc_base_approved") {
+  # TODO(kjellander): Remove (bugs.webrtc.org/6828)

[perkj_webrtc, 2017/04/04 09:30:59]

As I have understood it , rtc_base_approved should depend on no other webrtc
targets.
Can you file a separate bug on rtc_base_approved that says it should not depend
on other libs. you can also refer to 3806. 
and all problems you got when compiling without the deps you had in this Decide
with tommi who can/will work on it going forward.

[kjellander_webrtc, 2017/04/10 12:54:02]

I can file a bug, but let's wait and see what tommi/nisse responds to in the
previous comment threads first.

[kjellander_webrtc, 2017/04/12 11:51:45]

I filed https://bugs.chromium.org/p/webrtc/issues/detail?id=7480 for the
remaining work that is not covered in this CL (since my main goal here is to
cover webrtc/base in the root .gn file).
I updated the TODO with the new bug number instead.

+  # Enabling GN check triggers two cyclic dependency errors:
+  #   :rtc_base_approved -> :rtc_base -> :rtc_base_approved
+  #   :rtc_base_approved -> //webrtc/system_wrappers -> :rtc_base_approved
+  check_includes = false
   defines = []
   libs = []
   deps = []
   all_dependent_configs = [ ":rtc_base_approved_all_dependent_config" ]
 
   sources = [
     "array_view.h",
     "arraysize.h",
     "atomicops.h",
     "base64.cc",
@@ skipping 174 matching lines @@
       if (current_cpu == "x64") {
         data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-x86_64.dll" ]
       } else {
         data += [ "$clang_base_path/lib/clang/$clang_version/lib/windows/clang_rt.asan_dynamic-i386.dll" ]
       }
     }
   }
   if (is_nacl) {
     deps += [ "//native_client_sdk/src/libraries/nacl_io" ]
   }
+  deps += [ "..:webrtc_common" ]

[perkj_webrtc, 2017/04/04 09:30:59]

And add the todo and bug number here as well. Should not depend on
webrtc_common.

[kjellander_webrtc, 2017/04/12 11:51:45]

I don't see the problem with having dependencies on webrtc_common, almost every
project depends on it and it's a really small target:
https://cs.chromium.org/chromium/src/third_party/webrtc/BUILD.gn?rcl=1abcfb59...

 }
 
 config("enable_libevent_config") {
   defines = [ "WEBRTC_BUILD_LIBEVENT" ]
 }
 
 rtc_static_library("rtc_task_queue") {
   public_deps = [
     ":rtc_base_approved",
   ]
@@ skipping 362 matching lines @@
     }
   }
 
   rtc_source_set("rtc_base_tests_main") {
     testonly = true
     sources = [
       "unittest_main.cc",
     ]
     public_configs = [ ":rtc_base_tests_utils_exported_config" ]
     deps = [
+      ":rtc_base",
+      ":rtc_base_approved",
       ":rtc_base_tests_utils",
+      "../test:field_trial",
+      "../test:test_support",
     ]
     public_deps = [
       "//testing/gmock",
       "//testing/gtest",
     ]
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
@@ skipping 58 matching lines @@
       "nullsocketserver_unittest.cc",
       "physicalsocketserver_unittest.cc",
       "socket_unittest.cc",
       "socket_unittest.h",
       "socketaddress_unittest.cc",
       "virtualsocket_unittest.cc",
     ]
     deps = [
       ":rtc_base",
       ":rtc_base_tests_main",
+      ":rtc_base_tests_utils",
+      "../system_wrappers:system_wrappers",
+      "../test:test_support",
       "//testing/gtest",
     ]
     if (is_win) {
       sources += [ "win32socketserver_unittest.cc" ]
     }
 
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
@@ skipping 33 matching lines @@
       "safe_compare_unittest.cc",
       "stringencode_unittest.cc",
       "stringutils_unittest.cc",
       "swap_queue_unittest.cc",
       "thread_annotations_unittest.cc",
       "thread_checker_unittest.cc",
       "timestampaligner_unittest.cc",
       "timeutils_unittest.cc",
     ]
     deps = [
+      ":rtc_base",
       ":rtc_base_approved",
       ":rtc_base_tests_main",
+      ":rtc_base_tests_utils",
+      ":rtc_task_queue",
+      "../system_wrappers:system_wrappers",

[perkj_webrtc, 2017/04/04 09:30:59]

system_wrappers ? Is that needed? Same todo and bug number here then.

[kjellander_webrtc, 2017/04/12 11:51:45]

Yes it depends on system_wrappers. I'm not sure what bug you want me to add,
https://bugs.chromium.org/p/webrtc/issues/detail?id=3380 ?

+      "../test:test_support",
     ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 
   rtc_source_set("rtc_task_queue_unittests") {
     testonly = true
     sources = [
       "sequenced_task_checker_unittest.cc",
       "task_queue_unittest.cc",
       "weak_ptr_unittest.cc",
     ]
     deps = [
       ":rtc_base_tests_main",
+      ":rtc_base_tests_utils",
       ":rtc_task_queue",
+      "../test:test_support",
     ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 
   rtc_source_set("rtc_numerics_unittests") {
     testonly = true
     sources = [
       "numerics/exp_filter_unittest.cc",
       "numerics/percentile_filter_unittest.cc",
     ]
     deps = [
+      ":rtc_base_approved",
       ":rtc_base_tests_main",
       ":rtc_numerics",
+      "../test:test_support",
     ]
   }
 
   config("rtc_base_unittests_config") {
     if (is_clang) {
       cflags = [ "-Wno-unused-const-variable" ]
     }
   }
   rtc_source_set("rtc_base_unittests") {
     testonly = true
@@ skipping 39 matching lines @@
     }
     if (is_posix) {
       sources += [
         "ssladapter_unittest.cc",
         "sslidentity_unittest.cc",
         "sslstreamadapter_unittest.cc",
       ]
     }
     deps = [
       ":rtc_base_tests_main",
+      ":rtc_base_tests_utils",
+      "../test:test_support",
     ]
     public_deps = [
       ":rtc_base",
     ]
     configs += [ ":rtc_base_unittests_config" ]
     if (!build_with_chromium && is_clang) {
       # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
       suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
     }
   }
 }
 
 if (is_android) {
   android_library("base_java") {
     java_files = [
       "java/src/org/webrtc/Logging.java",
       "java/src/org/webrtc/Size.java",
       "java/src/org/webrtc/ThreadUtils.java",
     ]
   }
 }