Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: webrtc/call/call_perf_tests.cc

Issue 2716643002: Add framerate to VideoSinkWants and ability to signal on overuse (Closed)
Patch Set: Addressed comments, fixed missing include Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/call/call_perf_tests.cc
diff --git a/webrtc/call/call_perf_tests.cc b/webrtc/call/call_perf_tests.cc
index a421c24d56558fd29880f0074338b938b3a94a6e..d4067502c25e9841af9edfb27a7a4653bfb47a8e 100644
--- a/webrtc/call/call_perf_tests.cc
+++ b/webrtc/call/call_perf_tests.cc
@@ -494,14 +494,13 @@ TEST_F(CallPerfTest, ReceivesCpuOveruseAndUnderuse) {
// First expect CPU overuse. Then expect CPU underuse when the encoder
// delay has been decreased.
if (wants.target_pixel_count &&
- *wants.target_pixel_count <
- wants.max_pixel_count.value_or(std::numeric_limits<int>::max())) {
+ *wants.target_pixel_count < wants.max_pixel_count) {
// On adapting up, ViEEncoder::VideoSourceProxy will set the target
// pixel count to a step up from the current and the max value to
// something higher than the target.
EXPECT_FALSE(expect_lower_resolution_wants_);
observation_complete_.Set();
- } else if (wants.max_pixel_count) {
+ } else if (wants.max_pixel_count < std::numeric_limits<int>::max()) {
stefan-webrtc 2017/03/21 15:37:36 It's not clear to me what this change means. Can y
sprang_webrtc 2017/03/21 15:59:18 max_pixel_count is now a plain int instead of an r
// On adapting down, ViEEncoder::VideoSourceProxy will set only the max
// pixel count, leaving the target unset.
EXPECT_TRUE(expect_lower_resolution_wants_);

Powered by Google App Engine
This is Rietveld 408576698