Add PESQ precompiled tool for audio quality testing

tools-webrtc/download.py

Index: tools-webrtc/download.py
diff --git a/tools-webrtc/video_quality_toolchain/download.py b/tools-webrtc/download.py
similarity index 54%
rename from tools-webrtc/video_quality_toolchain/download.py
rename to tools-webrtc/download.py
index 24c243af15c698686f1fa5e3cd4d3820d35aa3d5..6c5140e8375c77c8783726995404ad5d0c682094 100755
--- a/tools-webrtc/video_quality_toolchain/download.py
+++ b/tools-webrtc/download.py
@@ -7,7 +7,7 @@
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
-"""Downloads precompiled tools needed for video quality analysis."""
+"""Downloads precompiled tools."""

[kjellander_webrtc, 2017/03/03 04:33:56]

Since this script is now more visible in the new location, it should have a
comment that explains why non-Googlers that try to run this will get an error.
See
https://chromium.googlesource.com/external/webrtc/+/master/tools-webrtc/video...
for inspiration.

[oprypin_webrtc, 2017/03/03 19:24:50]

Done.

 
 import os
 import subprocess
@@ -17,19 +17,23 @@ import sys
 SCRIPT_DIR = os.path.dirname(os.path.abspath(__file__))
 
 
-def main():
-  cmd = [
-    'download_from_google_storage',
-    '--directory',
-    '--num_threads=10',
-    '--bucket', 'chrome-webrtc-resources',
-    '--auto_platform',
-    '--recursive',
-    SCRIPT_DIR,
-  ]
-  print 'Downloading video quality analysis tools...'
-  subprocess.check_call(cmd)
+def main(directories):
+  if not directories:
+    directories = [SCRIPT_DIR]
+
+  for path in directories:
+    cmd = [
+      'download_from_google_storage',
+      '--directory',
+      '--num_threads=10',
+      '--bucket', 'chrome-webrtc-resources',
+      '--auto_platform',
+      '--recursive',
+      path,

[kjellander_webrtc, 2017/02/27 07:05:13]

Skip the directory handling in main() + the loop above and pass in SCRIPT_DIR
here instead. Since it's using --recursive it should find the files in both
audio_quality and video_quality_toolchain.

In case we'll need the script to be able to download publicly available
resources in the future, we can deal with that now (and those can likely go into
the resources/ dir anyway).

[oprypin_webrtc, 2017/03/02 17:30:08]

This is done so each test can specify what subdirectory to download when
executing this script, to skip unnecessary downloads. I think it adds
flexibility with very little overhead.
Keeping as is, but can change it if you insist.

[kjellander_webrtc, 2017/03/03 04:33:56]

Sure, that could be a useful feature as it works both if you specify a dir and
not. 
But you're going to have to update
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/examples/an...
then, so it calls the right script.

Also, since it's now located in tools-webrtc, I think download.py is suddenly a
too generic name. I suggest renaming to download_resources.py.

[oprypin_webrtc, 2017/03/03 19:24:50]

Done.

+    ]
+    print 'Downloading precompiled tools...'
+    subprocess.check_call(cmd)
 
 
 if __name__ == '__main__':
-  sys.exit(main())
+  sys.exit(main(sys.argv[1:]))