APM Quality Generator, noise generator and evaluation score workers factory + echo noise generator

webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py

Index: webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py
diff --git a/webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py b/webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py
index ca7e2c3e930fb609233cf500f057df033acf0c03..8d0f10dacc4aa5a816ba29a67bce93ae16c5e1b8 100755
--- a/webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py
+++ b/webrtc/modules/audio_processing/test/py_quality_assessment/apm_quality_assessment.py
@@ -19,6 +19,7 @@ Usage: apm_quality_assessment.py -i audio1.wav [audio2.wav ...]
 
 import argparse
 import logging
+import os
 import sys
 
 import quality_assessment.eval_scores as eval_scores
@@ -63,6 +64,20 @@ def _instance_arguments_parser():
                             'are saved'),
                       default='output')
 
+  default_polqa_path = None if 'POLQA_PATH' not in os.environ else (
+      os.environ['POLQA_PATH'])
+  parser.add_argument('--polqa_path', nargs='+',
+                      required=default_polqa_path is None,
+                      help='path to the POLQA tool',
+                      default=default_polqa_path)
+
+  default_air_db_path = None if 'AECHEN_IR_DATABASE_PATH' not in (
+      os.environ) else os.environ['AECHEN_IR_DATABASE_PATH']
+  parser.add_argument('--air_db_path', nargs='+',
+                      required=default_air_db_path is None,
+                      help='path to the Aechen IR database',
+                      default=default_air_db_path)
+

[AleBzk, 2017/03/06 11:29:53]

@kjellander: the environment variable, if defined, is now only used as default
for the shell arguments

[kjellander_webrtc, 2017/03/09 07:49:31]

That's better, but I'd still like to never even attempt to read an environment
variable though. I understand it's annoying to have to pass these flags every
time and that's why you want to define an environment variable. How about just
having a sensible default path instead, and eliminate the environment variable
access entirely?

[AleBzk, 2017/03/09 11:31:19]

Done. Now both paths are required and with no default. See the changes in
apm_quality_assessment.sh taking into account that the script is a sample
customizable script provided with the tool. Still, I defined a default path in
case the environment vars are not defined. But again, taking care of the paths
will be up to the user and now the Python code does not depend anymore on any
environment var.

[kjellander_webrtc, 2017/03/09 14:05:41]

Thanks! Environment variables are the cause of much evil in development and
infrastructure. That's why I'm so heavily against them.

   return parser
 
 
@@ -73,7 +88,9 @@ def main():
   parser = _instance_arguments_parser()
   args = parser.parse_args()
 
-  simulator = simulation.ApmModuleSimulator()
+  simulator = simulation.ApmModuleSimulator(
+      aechen_ir_database_path=args.air_db_path,
+      polqa_tool_path=args.polqa_path)

[AleBzk, 2017/03/06 11:29:53]

@kjellander: the required paths are now passed to the APM simulator

   simulator.run(
       config_filepaths=args.config_files,
       input_filepaths=args.input_files,