Create the SrtpTransportInterface.

webrtc/ortc/srtptransport_unittests.cc

+/*

[Taylor Brandstetter, 2017/03/01 19:18:09]

nit: File should be named "_unittest.cc" (singular), to match existing naming.

[Zhi Huang, 2017/03/02 23:35:39]

Done.

+ *  Copyright 2017 The WebRTC project authors. All Rights Reserved.
+ *
+ *  Use of this source code is governed by a BSD-style license
+ *  that can be found in the LICENSE file in the root of the source
+ *  tree. An additional intellectual property rights grant can be found
+ *  in the file PATENTS.  All contributing project authors may
+ *  be found in the AUTHORS file in the root of the source tree.
+ */
+
+#include <memory>
+
+#include "webrtc/base/gunit.h"
+#include "webrtc/media/base/fakemediaengine.h"
+#include "webrtc/ortc/ortcfactory.h"
+#include "webrtc/ortc/testrtpparameters.h"
+#include "webrtc/p2p/base/fakepackettransport.h"
+
+namespace webrtc {
+
+static const char kTestKeyParams1[] =
+    "inline:WVNfX19zZW1jdGwgKCkgewkyMjA7fQp9CnVubGVz";
+static const char kTestKeyParams2[] =
+    "inline:PS1uQCVeeCFCanVmcjkpPywjNWhcYD0mXXtxaVBR";
+
+static const cricket::CryptoParams kTestCryptoParams1(1,
+                                                      "AES_CM_128_HMAC_SHA1_80",
+                                                      kTestKeyParams1,
+                                                      "");
+static const cricket::CryptoParams kTestCryptoParams2(1,
+                                                      "AES_CM_128_HMAC_SHA1_80",
+                                                      kTestKeyParams2,
+                                                      "");
+
+// This test uses fake packet transports and a fake media engine, in order to
+// test the SrtpTransport at only an API level. Any end-to-end test should go in
+// ortcfactory_integrationtest.cc instead.
+class SrtpTransportTest : public testing::Test {
+ public:
+  SrtpTransportTest() {
+    fake_media_engine_ = new cricket::FakeMediaEngine();
+    // Note: This doesn't need to use fake network classes, since it uses
+    // FakePacketTransports.
+    auto result = OrtcFactory::Create(
+        nullptr, nullptr, nullptr, nullptr, nullptr,
+        std::unique_ptr<cricket::MediaEngineInterface>(fake_media_engine_));
+    ortc_factory_ = result.MoveValue();
+    rtp_transport_controller_ =
+        ortc_factory_->CreateRtpTransportController().MoveValue();
+
+    fake_packet_transport_.reset(new rtc::FakePacketTransport("fake"));
+    auto srtp_transport_result = ortc_factory_->CreateSrtpTransport(
+        rtcp_parameters_, fake_packet_transport_.get(), nullptr,
+        rtp_transport_controller_.get());
+    srtp_transport_ = srtp_transport_result.MoveValue();
+  }
+
+ protected:
+  // Owned by |ortc_factory_|.
+  cricket::FakeMediaEngine* fake_media_engine_;
+  std::unique_ptr<OrtcFactoryInterface> ortc_factory_;
+  std::unique_ptr<RtpTransportControllerInterface> rtp_transport_controller_;
+  std::unique_ptr<SrtpTransportInterface> srtp_transport_;
+  RtcpParameters rtcp_parameters_;
+  std::unique_ptr<rtc::FakePacketTransport> fake_packet_transport_;
+};
+
+// Tests that setting the SRTP send/receive key twice is not supported.
+TEST_F(SrtpTransportTest, SetSrtpSendAndReceiveKeyForSender) {

[Taylor Brandstetter, 2017/03/01 19:18:09]

Could you split this into two tests; one for setting the keys once (success
case) and one for setting them twice (error case)?

[Zhi Huang, 2017/03/02 23:35:39]

Done.

+  EXPECT_TRUE(srtp_transport_->SetSrtpSendKey(kTestCryptoParams1).ok());
+  EXPECT_TRUE(srtp_transport_->SetSrtpReceiveKey(kTestCryptoParams2).ok());
+  EXPECT_EQ(srtp_transport_->SetSrtpSendKey(kTestCryptoParams2).type(),
+            RTCErrorType::UNSUPPORTED_OPERATION);
+  EXPECT_EQ(srtp_transport_->SetSrtpReceiveKey(kTestCryptoParams1).type(),
+            RTCErrorType::UNSUPPORTED_OPERATION);
+  auto sender_result = ortc_factory_->CreateRtpSender(cricket::MEDIA_TYPE_AUDIO,
+                                                      srtp_transport_.get());
+  EXPECT_TRUE(sender_result.ok());
+  auto receiver_result = ortc_factory_->CreateRtpReceiver(
+      cricket::MEDIA_TYPE_AUDIO, srtp_transport_.get());
+  EXPECT_TRUE(receiver_result.ok());
+}
+
+class SrtpTransportTestWithMediaType
+    : public SrtpTransportTest,
+      public ::testing::WithParamInterface<cricket::MediaType> {};
+
+// Tests that the senders cannot be created before setting the keys.
+TEST_P(SrtpTransportTestWithMediaType, CreateSenderBeforeSettingKeys) {
+  auto sender_result =
+      ortc_factory_->CreateRtpSender(GetParam(), srtp_transport_.get());
+  EXPECT_FALSE(sender_result.ok());

[Taylor Brandstetter, 2017/03/01 19:18:09]

nit: Verify that the error is "UNSUPPORTED_PARAMETER"?

[Zhi Huang, 2017/03/02 23:35:40]

Done.

+  EXPECT_TRUE(srtp_transport_->SetSrtpSendKey(kTestCryptoParams1).ok());
+  sender_result =
+      ortc_factory_->CreateRtpSender(GetParam(), srtp_transport_.get());
+  EXPECT_FALSE(sender_result.ok());

[Taylor Brandstetter, 2017/03/01 19:18:09]

nit: Add comment saying something along the lines of "Ensure that after the keys
*are* set, a sender can be created, despite the previous errors."

[Zhi Huang, 2017/03/02 23:35:39]

Done.

+  EXPECT_TRUE(srtp_transport_->SetSrtpReceiveKey(kTestCryptoParams2).ok());
+  sender_result =
+      ortc_factory_->CreateRtpSender(GetParam(), srtp_transport_.get());
+  EXPECT_TRUE(sender_result.ok());
+}
+
+// Tests that the receivers cannot be created before setting the keys.
+TEST_P(SrtpTransportTestWithMediaType, CreateReceiverBeforeSettingKeys) {
+  auto receiver_result =
+      ortc_factory_->CreateRtpReceiver(GetParam(), srtp_transport_.get());
+  EXPECT_FALSE(receiver_result.ok());
+  EXPECT_TRUE(srtp_transport_->SetSrtpSendKey(kTestCryptoParams1).ok());
+  receiver_result =
+      ortc_factory_->CreateRtpReceiver(GetParam(), srtp_transport_.get());
+  EXPECT_FALSE(receiver_result.ok());
+  EXPECT_TRUE(srtp_transport_->SetSrtpReceiveKey(kTestCryptoParams2).ok());
+  receiver_result =
+      ortc_factory_->CreateRtpReceiver(GetParam(), srtp_transport_.get());
+  EXPECT_TRUE(receiver_result.ok());
+}
+
+INSTANTIATE_TEST_CASE_P(SenderCreatationTest,
+                        SrtpTransportTestWithMediaType,
+                        ::testing::Values(cricket::MEDIA_TYPE_AUDIO,
+                                          cricket::MEDIA_TYPE_VIDEO));

[Taylor Brandstetter, 2017/03/01 19:18:09]

This is smart! I should have done this with some of the other tests I wrote.

+
+}  // namespace webrtc