Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Unified Diff: chromecast/public/avsettings.h

Issue 2712883006: [Chromecast] Add new volume control API to CastMediaShlib (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromecast/public/BUILD.gn ('k') | chromecast/public/media/media_pipeline_device_params.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/public/avsettings.h
diff --git a/chromecast/public/avsettings.h b/chromecast/public/avsettings.h
index 0b99842bfc3c48fa2d961643503d08593f978985..311bf341dc9467cce1a310322048826867b00e56 100644
--- a/chromecast/public/avsettings.h
+++ b/chromecast/public/avsettings.h
@@ -73,6 +73,8 @@ class AvSettings {
// Initialize() was called.
ACTIVE_STATE_CHANGED = 0,
+ // DEPRECATED - Prefer to implement volume control in the media shlib using
+ // the VolumeControl API (see chromecast/public/volume_control.h).
// This event shall be fired whenever the system volume level or muted state
// are changed including when user changed volume via a remote controller,
// or after a call to SetAudioVolume() or SetAudioMuted().
@@ -203,19 +205,27 @@ class AvSettings {
// - UNKNOWN_VOLUME: 0.01 (1%)
virtual bool GetAudioVolumeStepInterval(float* step_inteval) = 0;
+ // DEPRECATED - Prefer to implement volume control in the media shlib using
+ // the VolumeControl API (see chromecast/public/volume_control.h).
// Returns the current volume level, which must be from 0.0 (inclusive) to
// 1.0 (inclusive).
virtual float GetAudioVolume() = 0;
+ // DEPRECATED - Prefer to implement volume control in the media shlib using
+ // the VolumeControl API (see chromecast/public/volume_control.h).
// Sets new volume level of the device (or HDMI sinks). |level| is from 0.0
// (inclusive) to 1.0 (inclusive).
// If successful and the level has changed, it must return true and fire
// AUDIO_VOLUME_CHANGED.
virtual bool SetAudioVolume(float level) = 0;
+ // DEPRECATED - Prefer to implement volume control in the media shlib using
+ // the VolumeControl API (see chromecast/public/volume_control.h).
// Whether or not the device (or HDMI sinks) is muted.
virtual bool IsAudioMuted() = 0;
+ // DEPRECATED - Prefer to implement volume control in the media shlib using
+ // the VolumeControl API (see chromecast/public/volume_control.h).
// Sets the device (or HDMI sinks) muted.
// If successful and the muted state has changed, it must return true and fire
// AUDIO_VOLUME_CHANGED.
« no previous file with comments | « chromecast/public/BUILD.gn ('k') | chromecast/public/media/media_pipeline_device_params.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698