Support 4 channel mic in Windows Core Audio

webrtc/audio/utility/audio_frame_operations_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/audio/utility/audio_frame_operations.h"
 #include "webrtc/base/checks.h"
 #include "webrtc/modules/include/module_common_types.h"
 #include "webrtc/test/gtest.h"
 
 namespace webrtc {
 namespace {
 
 class AudioFrameOperationsTest : public ::testing::Test {
  protected:
   AudioFrameOperationsTest() {
     // Set typical values.
     frame_.samples_per_channel_ = 320;
     frame_.num_channels_ = 2;
   }
 
   AudioFrame frame_;
 };
 
+void SetFrameData(AudioFrame* frame, int16_t ch1, int16_t ch2,

[hlundin-webrtc, 2017/02/24 09:46:36]

Please, run "git cl format" on your patch.

[jens.nielsen, 2017/02/24 14:55:49]

Done.

+                  int16_t ch3, int16_t ch4) {

[aleloi, 2017/02/24 10:39:32]

Please change parameter ordering: input params first, both input and output
after.

[jens.nielsen, 2017/02/24 14:55:49]

Done.

+  for (size_t i = 0; i < frame->samples_per_channel_ * 4; i += 4) {
+    frame->data_[i] = ch1;
+    frame->data_[i + 1] = ch2;
+    frame->data_[i + 2] = ch3;
+    frame->data_[i + 3] = ch4;
+  }
+}
+
 void SetFrameData(AudioFrame* frame, int16_t left, int16_t right) {
   for (size_t i = 0; i < frame->samples_per_channel_ * 2; i += 2) {
     frame->data_[i] = left;
     frame->data_[i + 1] = right;
   }
 }
 
 void SetFrameData(AudioFrame* frame, int16_t data) {
   for (size_t i = 0; i < frame->samples_per_channel_; i++) {
     frame->data_[i] = data;
@@ skipping 98 matching lines @@
   SetFrameData(&frame_, -32768, -32768);
   EXPECT_EQ(0, AudioFrameOperations::StereoToMono(&frame_));
 
   AudioFrame mono_frame;
   mono_frame.samples_per_channel_ = 320;
   mono_frame.num_channels_ = 1;
   SetFrameData(&mono_frame, -32768);
   VerifyFramesAreEqual(mono_frame, frame_);
 }
 
+TEST_F(AudioFrameOperationsTest, QuadToMonoFailsWithBadParameters) {
+  frame_.num_channels_ = 1;
+  EXPECT_EQ(-1, AudioFrameOperations::QuadToMono(&frame_));
+  frame_.num_channels_ = 2;
+  EXPECT_EQ(-1, AudioFrameOperations::QuadToMono(&frame_));
+}
+
+TEST_F(AudioFrameOperationsTest, QuadToMonoSucceeds) {
+  frame_.num_channels_ = 4;
+  SetFrameData(&frame_, 4, 2, 6, 8);
+  AudioFrame temp_frame;
+  temp_frame.CopyFrom(frame_);
+  EXPECT_EQ(0, AudioFrameOperations::QuadToMono(&frame_));
+
+  AudioFrame mono_frame;
+  mono_frame.samples_per_channel_ = 320;
+  mono_frame.num_channels_ = 1;
+  SetFrameData(&mono_frame, 5);
+  VerifyFramesAreEqual(mono_frame, frame_);
+
+  SetFrameData(&frame_, 0);

[hlundin-webrtc, 2017/02/24 09:46:36]

Let this be a separate TEST_F. This will also avoid the strange reuse of
temp_frame and frame_.

[jens.nielsen, 2017/02/24 11:11:19]

Will do. Should I also change the StereoToMono and MonoToStereo tests this was
copied from?

[jens.nielsen, 2017/02/24 14:55:49]

Done.

[hlundin-webrtc, 2017/02/27 07:52:02]

That is up to you. I think you are living by the Boy Scout Rule anyway, leaving
the code better than you found it. But if you want to improve it even further...
:)

[jens.nielsen, 2017/02/27 13:28:15]

Alright I was reluctant to change too much in one CL, but I couldn't stay away
and applied the comments on the functions I added also to the already existing
code :)

+  AudioFrameOperations::QuadToMono(temp_frame.data_,
+                                   frame_.samples_per_channel_,
+                                   frame_.data_);
+  frame_.num_channels_ = 1;  // Need to set manually.
+  VerifyFramesAreEqual(mono_frame, frame_);
+}
+
+TEST_F(AudioFrameOperationsTest, QuadToMonoDoesNotWrapAround) {
+  frame_.num_channels_ = 4;
+  SetFrameData(&frame_, -32768, -32768, -32768, -32768);
+  EXPECT_EQ(0, AudioFrameOperations::QuadToMono(&frame_));
+
+  AudioFrame mono_frame;
+  mono_frame.samples_per_channel_ = 320;
+  mono_frame.num_channels_ = 1;
+  SetFrameData(&mono_frame, -32768);
+  VerifyFramesAreEqual(mono_frame, frame_);
+}
+
+TEST_F(AudioFrameOperationsTest, QuadToStereoFailsWithBadParameters) {
+  frame_.num_channels_ = 1;
+  EXPECT_EQ(-1, AudioFrameOperations::QuadToStereo(&frame_));
+  frame_.num_channels_ = 2;
+  EXPECT_EQ(-1, AudioFrameOperations::QuadToStereo(&frame_));
+}
+
+TEST_F(AudioFrameOperationsTest, QuadToStereoSucceeds) {
+  frame_.num_channels_ = 4;
+  SetFrameData(&frame_, 4, 2, 6, 8);
+  AudioFrame temp_frame;
+  temp_frame.CopyFrom(frame_);
+  EXPECT_EQ(0, AudioFrameOperations::QuadToStereo(&frame_));
+
+  AudioFrame stereo_frame;
+  stereo_frame.samples_per_channel_ = 320;
+  stereo_frame.num_channels_ = 2;
+  SetFrameData(&stereo_frame, 3, 7);
+  VerifyFramesAreEqual(stereo_frame, frame_);
+
+  SetFrameData(&frame_, 0);
+  AudioFrameOperations::QuadToStereo(temp_frame.data_,

[hlundin-webrtc, 2017/02/24 09:46:36]

Let this be a separate TEST_F.

[jens.nielsen, 2017/02/24 14:55:49]

Done.

+                                     frame_.samples_per_channel_,
+                                     frame_.data_);
+  frame_.num_channels_ = 2;  // Need to set manually.
+  VerifyFramesAreEqual(stereo_frame, frame_);
+}
+
+TEST_F(AudioFrameOperationsTest, QuadToStereoDoesNotWrapAround) {
+  frame_.num_channels_ = 4;
+  SetFrameData(&frame_, -32768, -32768, -32768, -32768);
+  EXPECT_EQ(0, AudioFrameOperations::QuadToStereo(&frame_));
+
+  AudioFrame stereo_frame;
+  stereo_frame.samples_per_channel_ = 320;
+  stereo_frame.num_channels_ = 2;
+  SetFrameData(&stereo_frame, -32768, -32768);
+  VerifyFramesAreEqual(stereo_frame, frame_);
+}
+
 TEST_F(AudioFrameOperationsTest, SwapStereoChannelsSucceedsOnStereo) {
   SetFrameData(&frame_, 0, 1);
 
   AudioFrame swapped_frame;
   swapped_frame.samples_per_channel_ = 320;
   swapped_frame.num_channels_ = 2;
   SetFrameData(&swapped_frame, 1, 0);
 
   AudioFrameOperations::SwapStereoChannels(&frame_);
   VerifyFramesAreEqual(swapped_frame, frame_);
@@ skipping 222 matching lines @@
   frame_to_add_to.samples_per_channel_ = frame_.samples_per_channel_;
   frame_to_add_to.num_channels_ = frame_.num_channels_;
   SetFrameData(&frame_to_add_to, 1000);
 
   AudioFrameOperations::Add(frame_, &frame_to_add_to);
   SetFrameData(&frame_, frame_.data_[0] + 1000);
   VerifyFramesAreEqual(frame_, frame_to_add_to);
 }
 }  // namespace
 }  // namespace webrtc