Parallel iterator bash script for the quality assessment package.

webrtc/modules/audio_processing/test/py_quality_assessment/BUILD.gn

+# Copyright (c) 2017 The WebRTC project authors. All Rights Reserved.
+#
+# Use of this source code is governed by a BSD-style license
+# that can be found in the LICENSE file in the root of the source
+# tree. An additional intellectual property rights grant can be found
+# in the file PATENTS.  All contributing project authors may
+# be found in the AUTHORS file in the root of the source tree.
+
+import("../../../../webrtc.gni")
+
+copy("lib") {
+  testonly = true
+  sources = [
+    "quality_assessment/__init__.py",
+  ]

[aleloi, 2017/02/23 14:48:24]

I suggest adding 'visibility = [ ":" ]' (hope the syntax is correct) here and in
:apm_configs. It means that the targets cannot be depended upon outside of this
file.

+  outputs = [
+    "$root_build_dir/py_quality_assessment/quality_assessment/{{source_file_part}}",
+  ]
+  deps = [
+    "//resources/audio_processing/test/py_quality_assessment:noise_tracks",
+  ]
+}  # lib
+
+copy("apm_configs") {
+  testonly = true
+  sources = [
+    "quality_assessment/apm_configs/default.json",
+  ]
+  outputs = [
+    "$root_build_dir/py_quality_assessment/apm_configs/{{source_file_part}}",
+  ]
+}  # apm_configs
+
+copy("py_quality_assessment") {

[aleloi, 2017/02/23 14:48:24]

Please move this to the beginning of the file.

See
https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/style_g...


Extract:

'Most BUILD files should have a target with the same name of the directory. This
target should be the first target.'

+  testonly = true
+  sources = [
+    "README",
+    "apm_quality_assessment-export.py",
+    "apm_quality_assessment-gencfgs.py",
+    "apm_quality_assessment.py",
+    "apm_quality_assessment.sh",
+  ]
+  outputs = [
+    "$root_build_dir/py_quality_assessment/{{source_file_part}}",
+  ]
+  deps = [
+    ":apm_configs",
+    ":lib",
+    "../..:audioproc_f",
+    "//resources/audio_processing/test/py_quality_assessment:probing_signals",
+  ]
+}  # py_quality_assessment