[sync] Fix roaming profile path for local sync database file.

[sync] Fix roaming profile path for local sync database file.

The file was missing the Google prefix to make it equal to the
local profile location.

This is only a temporary fix before the proper branded name can
be used to make Branded and non-branded Chromium builds name the
location properly.

BUG=694464
TEST=Manual check that the right path is used.

Review-Url: https://codereview.chromium.org/2709693002
Cr-Commit-Position: refs/heads/master@{#451984}
Committed: https://chromium.googlesource.com/chromium/src/+/314cce71dbd6d223bef618da475a81831840d74a

[pastarmovj, 2017-02-21 15:04:55]

pastarmovj@chromium.org changed reviewers:
+ zea@chromium.org

[pastarmovj, 2017-02-21 15:04:55]

Hi Nicolas,

While testing local sync I noticed that the way the path is constructed for the
roaming profile differs from the usual path. The usual one is
<some_base_dir>\Google\Chrome\User Data\<profile> and the one used in local sync
is <some_other_base_dir>\Chrome\User Data\<profile>.

Since we would like to fix this for 57 when we will try to get some users to
test this feature. I crafted a stop-gap fix which is in this CL and is small
enough to make the argument to merge in 57. And in roder to prove (to you and to
me ;) ) that I will not let it at this also a proper solution based on the
planned work in crbug.com/657810. Created in
https://codereview.chromium.org/2709783002/ and
https://codereview.chromium.org/2710623003/. 

Please take a look at both the stopgap here and the proper solution in the
linked CL (which I will send for review too.)

Thanks,
Julian

[Nicolas Zea, 2017-02-21 23:27:27]

lgtm

[pastarmovj, 2017-02-22 07:59:48]

The CQ bit was checked by pastarmovj@chromium.org

[pastarmovj, 2017-02-22 07:59:48]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/2709693002/#ps20001
(title: "Remove wrong upstream patch dependency.")

[commit-bot: I haz the power, 2017-02-22 08:00:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 09:40:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 09:40:12]

Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pastarmovj, 2017-02-22 09:41:22]

The CQ bit was checked by pastarmovj@chromium.org

[commit-bot: I haz the power, 2017-02-22 09:42:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 10:46:38]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487756482072770,
"parent_rev": "26f01531f9e0ecd2e0cde6cf5dacb0e4b70610ce", "commit_rev":
"314cce71dbd6d223bef618da475a81831840d74a"}

[commit-bot: I haz the power, 2017-02-22 10:47:15]

Description was changed from

==========
[sync] Fix roaming profile path for local sync database file.

The file was missing the Google prefix to make it equal to the
local profile location.

This is only a temporary fix before the proper branded name can
be used to make Branded and non-branded Chromium builds name the
location properly.

BUG=694464
TEST=Manual check that the right path is used.
==========

to

==========
[sync] Fix roaming profile path for local sync database file.

The file was missing the Google prefix to make it equal to the
local profile location.

This is only a temporary fix before the proper branded name can
be used to make Branded and non-branded Chromium builds name the
location properly.

BUG=694464
TEST=Manual check that the right path is used.

Review-Url: https://codereview.chromium.org/2709693002
Cr-Commit-Position: refs/heads/master@{#451984}
Committed:
https://chromium.googlesource.com/chromium/src/+/314cce71dbd6d223bef618da475a...
==========

[commit-bot: I haz the power, 2017-02-22 10:47:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/314cce71dbd6d223bef618da475a...