Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: webrtc/p2p/base/port.h

Issue 2709293004: RTCIceCandidatePairStats.nominated collected. (Closed)
Patch Set: Updated comment Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/p2p/base/jseptransport.cc ('k') | webrtc/p2p/base/port.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/p2p/base/port.h
diff --git a/webrtc/p2p/base/port.h b/webrtc/p2p/base/port.h
index f6900210f4417e35da6384eaeba7b54433d43b46..a80fde79a9c40229a6b3759dba11abb7da51861c 100644
--- a/webrtc/p2p/base/port.h
+++ b/webrtc/p2p/base/port.h
@@ -531,7 +531,14 @@ class Connection : public CandidatePairInterface,
void set_nomination(uint32_t value) { nomination_ = value; }
uint32_t remote_nomination() const { return remote_nomination_; }
- bool nominated() const { return remote_nomination_ > 0; }
+ // One or several pairs may be nominated based on if Regular or Aggressive
+ // Nomination is used. https://tools.ietf.org/html/rfc5245#section-8
+ // |nominated| is defined both for the controlling or controlled agent based
+ // on if a nomination has been pinged or acknowledged. The controlled agent
+ // gets its |remote_nomination_| set when pinged by the controlling agent with
+ // a nomination value. The controlling agent gets its |acked_nomination_| set
+ // when receiving a response to a nominating ping.
+ bool nominated() const { return acked_nomination_ || remote_nomination_; }
// Public for unit tests.
void set_remote_nomination(uint32_t remote_nomination) {
remote_nomination_ = remote_nomination;
« no previous file with comments | « webrtc/p2p/base/jseptransport.cc ('k') | webrtc/p2p/base/port.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698