Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Side by Side Diff: webrtc/pc/rtcstatscollector.cc

Issue 2709293004: RTCIceCandidatePairStats.nominated collected. (Closed)
Patch Set: Updated comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/pc/rtcstats_integrationtest.cc ('k') | webrtc/pc/rtcstatscollector_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2016 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2016 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 848 matching lines...) Expand 10 before | Expand all | Expand 10 after
859 // anything. We don't have a complete list. Local candidates come from 859 // anything. We don't have a complete list. Local candidates come from
860 // Port objects, and prflx candidates (both local and remote) are only 860 // Port objects, and prflx candidates (both local and remote) are only
861 // stored in candidate pairs. crbug.com/632723 861 // stored in candidate pairs. crbug.com/632723
862 candidate_pair_stats->local_candidate_id = ProduceIceCandidateStats( 862 candidate_pair_stats->local_candidate_id = ProduceIceCandidateStats(
863 timestamp_us, info.local_candidate, true, transport_id, report); 863 timestamp_us, info.local_candidate, true, transport_id, report);
864 candidate_pair_stats->remote_candidate_id = ProduceIceCandidateStats( 864 candidate_pair_stats->remote_candidate_id = ProduceIceCandidateStats(
865 timestamp_us, info.remote_candidate, false, transport_id, report); 865 timestamp_us, info.remote_candidate, false, transport_id, report);
866 candidate_pair_stats->state = 866 candidate_pair_stats->state =
867 IceCandidatePairStateToRTCStatsIceCandidatePairState(info.state); 867 IceCandidatePairStateToRTCStatsIceCandidatePairState(info.state);
868 candidate_pair_stats->priority = info.priority; 868 candidate_pair_stats->priority = info.priority;
869 candidate_pair_stats->nominated = info.nominated;
869 // TODO(hbos): This writable is different than the spec. It goes to 870 // TODO(hbos): This writable is different than the spec. It goes to
870 // false after a certain amount of time without a response passes. 871 // false after a certain amount of time without a response passes.
871 // crbug.com/633550 872 // crbug.com/633550
872 candidate_pair_stats->writable = info.writable; 873 candidate_pair_stats->writable = info.writable;
873 candidate_pair_stats->bytes_sent = 874 candidate_pair_stats->bytes_sent =
874 static_cast<uint64_t>(info.sent_total_bytes); 875 static_cast<uint64_t>(info.sent_total_bytes);
875 candidate_pair_stats->bytes_received = 876 candidate_pair_stats->bytes_received =
876 static_cast<uint64_t>(info.recv_total_bytes); 877 static_cast<uint64_t>(info.recv_total_bytes);
877 // TODO(hbos): The |info.rtt| measurement is smoothed. It shouldn't be 878 // TODO(hbos): The |info.rtt| measurement is smoothed. It shouldn't be
878 // smoothed according to the spec. crbug.com/633550. See 879 // smoothed according to the spec. crbug.com/633550. See
(...skipping 367 matching lines...) Expand 10 before | Expand all | Expand 10 after
1246 const std::string& type) { 1247 const std::string& type) {
1247 return CandidateTypeToRTCIceCandidateType(type); 1248 return CandidateTypeToRTCIceCandidateType(type);
1248 } 1249 }
1249 1250
1250 const char* DataStateToRTCDataChannelStateForTesting( 1251 const char* DataStateToRTCDataChannelStateForTesting(
1251 DataChannelInterface::DataState state) { 1252 DataChannelInterface::DataState state) {
1252 return DataStateToRTCDataChannelState(state); 1253 return DataStateToRTCDataChannelState(state);
1253 } 1254 }
1254 1255
1255 } // namespace webrtc 1256 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/pc/rtcstats_integrationtest.cc ('k') | webrtc/pc/rtcstatscollector_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698