Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: tools/perf/benchmarks/v8_browsing.py

Issue 2709173002: [perfbot health] Disable v8.runtimestats.browsing_mobile benchmarks. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import re 5 import re
6 6
7 from benchmarks import v8_helper 7 from benchmarks import v8_helper
8 from core import perf_benchmark 8 from core import perf_benchmark
9 from telemetry import benchmark 9 from telemetry import benchmark
10 from telemetry.timeline import chrome_trace_config 10 from telemetry.timeline import chrome_trace_config
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 def SetExtraBrowserOptions(self, options): 226 def SetExtraBrowserOptions(self, options):
227 super(V8RuntimeStatsDesktopTurboBrowsingBenchmark, 227 super(V8RuntimeStatsDesktopTurboBrowsingBenchmark,
228 self).SetExtraBrowserOptions(options) 228 self).SetExtraBrowserOptions(options)
229 v8_helper.EnableTurbo(options) 229 v8_helper.EnableTurbo(options)
230 230
231 @classmethod 231 @classmethod
232 def ShouldDisable(cls, possible_browser): 232 def ShouldDisable(cls, possible_browser):
233 return possible_browser.platform.GetDeviceTypeName() != 'Desktop' 233 return possible_browser.platform.GetDeviceTypeName() != 'Desktop'
234 234
235 235
236 @benchmark.Disabled('reference') # http://crbug.com/694658
236 class V8RuntimeStatsMobileBrowsingBenchmark( 237 class V8RuntimeStatsMobileBrowsingBenchmark(
237 _V8RuntimeStatsBrowsingBenchmark): 238 _V8RuntimeStatsBrowsingBenchmark):
238 PLATFORM = 'mobile' 239 PLATFORM = 'mobile'
239 TEST_SUFFIX = '' 240 TEST_SUFFIX = ''
240 241
241 def SetExtraBrowserOptions(self, options): 242 def SetExtraBrowserOptions(self, options):
242 super(V8RuntimeStatsMobileBrowsingBenchmark, 243 super(V8RuntimeStatsMobileBrowsingBenchmark,
243 self).SetExtraBrowserOptions(options) 244 self).SetExtraBrowserOptions(options)
244 v8_helper.EnableTurbo(options) 245 v8_helper.EnableTurbo(options)
245 246
246 @classmethod 247 @classmethod
247 def ShouldDisable(cls, possible_browser): 248 def ShouldDisable(cls, possible_browser):
248 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' 249 return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
249 250
250 251
252 @benchmark.Disabled('reference') # http://crbug.com/694658
251 class V8RuntimeStatsMobileTurboBrowsingBenchmark( 253 class V8RuntimeStatsMobileTurboBrowsingBenchmark(
252 _V8RuntimeStatsBrowsingBenchmark): 254 _V8RuntimeStatsBrowsingBenchmark):
253 PLATFORM = 'mobile' 255 PLATFORM = 'mobile'
254 TEST_SUFFIX = '_turbo' 256 TEST_SUFFIX = '_turbo'
255 257
256 def SetExtraBrowserOptions(self, options): 258 def SetExtraBrowserOptions(self, options):
257 super(V8RuntimeStatsMobileTurboBrowsingBenchmark, 259 super(V8RuntimeStatsMobileTurboBrowsingBenchmark,
258 self).SetExtraBrowserOptions(options) 260 self).SetExtraBrowserOptions(options)
259 v8_helper.EnableTurbo(options) 261 v8_helper.EnableTurbo(options)
260 262
261 @classmethod 263 @classmethod
262 def ShouldDisable(cls, possible_browser): 264 def ShouldDisable(cls, possible_browser):
263 return possible_browser.platform.GetDeviceTypeName() == 'Desktop' 265 return possible_browser.platform.GetDeviceTypeName() == 'Desktop'
264 266
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698