webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc - Issue 2708873003: Propagate packet pacing information to SendTimeHistory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

Issue 2708873003: Propagate packet pacing information to SendTimeHistory. (Closed)

Patch Set: TransportFeedbackAdapterTest fix. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/remote_bitrate_estimator/send_time_history_unittest.cc ('k') | webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

index a53ca6834b56d1dadea9fef883d787d7361530e5..bf52c826e200984924bdd09949aaf679e5551b87 100644

--- a/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

+++ b/webrtc/modules/remote_bitrate_estimator/test/estimators/send_side.cc

@@ -112,7 +112,7 @@ void SendSideBweSender::OnPacketsSent(const Packets& packets) {

// to create tests for probing using cluster ids.

send_time_history_.AddAndRemoveOld(media_packet->header().sequenceNumber,

media_packet->payload_size(),

- PacedPacketInfo::kNotAProbe);

+ PacedPacketInfo());

send_time_history_.OnSentPacket(media_packet->header().sequenceNumber,

media_packet->sender_timestamp_ms());

}

@@ -142,9 +142,10 @@ SendSideBweReceiver::~SendSideBweReceiver() {

void SendSideBweReceiver::ReceivePacket(int64_t arrival_time_ms,

const MediaPacket& media_packet) {

- packet_feedback_vector_.push_back(PacketInfo(

- -1, arrival_time_ms, media_packet.sender_timestamp_ms(),

- media_packet.header().sequenceNumber, media_packet.payload_size(), true));

+ packet_feedback_vector_.push_back(

+ PacketInfo(-1, arrival_time_ms, media_packet.sender_timestamp_ms(),

+ media_packet.header().sequenceNumber,

+ media_packet.payload_size(), PacedPacketInfo()));

// Log received packet information.

BweReceiver::ReceivePacket(arrival_time_ms, media_packet);