webrtc/system_wrappers/source/critical_section_unittest.cc - Issue 2708723003: Introduce new constructor to PlatformThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/system_wrappers/source/critical_section_unittest.cc

Issue 2708723003: Introduce new constructor to PlatformThread. (Closed)

Patch Set: Disable RTC_DCHECK in channel_proxy + add TODO Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/system_wrappers/source/critical_section_unittest.cc

diff --git a/webrtc/system_wrappers/source/critical_section_unittest.cc b/webrtc/system_wrappers/source/critical_section_unittest.cc

index 6d73242f6a173f2299ff37d885725fc7e5ef185c..f6ceff7c2f3b395dbcaba3af7a0633c01dad0b34 100644

--- a/webrtc/system_wrappers/source/critical_section_unittest.cc

+++ b/webrtc/system_wrappers/source/critical_section_unittest.cc

@@ -68,10 +68,9 @@ public:

}

};

-bool LockUnlockThenStopRunFunction(void* obj) {

+void LockUnlockThenStopRunFunction(void* obj) {

ProtectedCount* the_count = static_cast<ProtectedCount*>(obj);

the_count->Increment();

- return false;

}

TEST_F(CritSectTest, ThreadWakesOnce) NO_THREAD_SAFETY_ANALYSIS {