Chromium Code Reviews

Unified Diff: webrtc/call/rampup_tests.h

Issue 2708723003: Introduce new constructor to PlatformThread. (Closed)
Patch Set: Disable RTC_DCHECK in channel_proxy + add TODO Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
« no previous file with comments | « webrtc/base/task_queue_win.cc ('k') | webrtc/call/rampup_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/call/rampup_tests.h
diff --git a/webrtc/call/rampup_tests.h b/webrtc/call/rampup_tests.h
index 65276ea265c820c37389ac947f4462332619a990..b9fd5974eedd7c81e3a9f5c5a2b2ee390e042d55 100644
--- a/webrtc/call/rampup_tests.h
+++ b/webrtc/call/rampup_tests.h
@@ -49,7 +49,7 @@ class RampUpTester : public test::EndToEndTest {
void PerformTest() override;
protected:
- virtual bool PollStats();
+ virtual void PollStats();
void AccumulateStats(const VideoSendStream::StreamStats& stream,
size_t* total_packets_sent,
@@ -63,7 +63,7 @@ class RampUpTester : public test::EndToEndTest {
void TriggerTestDone();
webrtc::RtcEventLogNullImpl event_log_;
- rtc::Event event_;
+ rtc::Event stop_event_;
Clock* const clock_;
FakeNetworkPipe::Config forward_transport_config_;
const size_t num_video_streams_;
@@ -95,7 +95,7 @@ class RampUpTester : public test::EndToEndTest {
std::vector<FlexfecReceiveStream::Config>* receive_configs) override;
void OnCallsCreated(Call* sender_call, Call* receiver_call) override;
- static bool BitrateStatsPollingThread(void* obj);
+ static void BitrateStatsPollingThread(void* obj);
const int start_bitrate_bps_;
const int64_t min_run_time_ms_;
@@ -125,7 +125,7 @@ class RampUpDownUpTester : public RampUpTester {
~RampUpDownUpTester() override;
protected:
- bool PollStats() override;
+ void PollStats() override;
private:
enum TestStates {
« no previous file with comments | « webrtc/base/task_queue_win.cc ('k') | webrtc/call/rampup_tests.cc » ('j') | no next file with comments »

Powered by Google App Engine