Introduce new constructor to PlatformThread.

webrtc/base/platform_thread_unittest.cc

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
 #include "webrtc/base/platform_thread.h"
 
 #include "webrtc/system_wrappers/include/sleep.h"
 #include "webrtc/test/gtest.h"
 
 namespace rtc {
 namespace {
 // Function that does nothing, and reports success.
-bool NullRunFunction(void* obj) {
+bool NullRunFunctionDeprecated(void* obj) {
   webrtc::SleepMs(0);  // Hand over timeslice, prevents busy looping.
   return true;
 }
 
+void NullRunFunction(void* obj) {}
+
 // Function that sets a boolean.
-bool SetFlagRunFunction(void* obj) {
+bool SetFlagRunFunctionDeprecated(void* obj) {
   bool* obj_as_bool = static_cast<bool*>(obj);
   *obj_as_bool = true;
   webrtc::SleepMs(0);  // Hand over timeslice, prevents busy looping.
   return true;
 }
+
+void SetFlagRunFunction(void* obj) {
+  bool* obj_as_bool = static_cast<bool*>(obj);
+  *obj_as_bool = true;
+}
+
 }  // namespace
 
+TEST(PlatformThreadTest, StartStopDeprecated) {
+  PlatformThread thread(&NullRunFunctionDeprecated, nullptr,
+                        "PlatformThreadTest");
+  EXPECT_TRUE(thread.name() == "PlatformThreadTest");
+  EXPECT_TRUE(thread.GetThreadRef() == 0);
+  thread.Start();
+  EXPECT_TRUE(thread.GetThreadRef() != 0);
+  thread.Stop();
+  EXPECT_TRUE(thread.GetThreadRef() == 0);
+}
+
+TEST(PlatformThreadTest, StartStop2Deprecated) {
+  PlatformThread thread1(&NullRunFunctionDeprecated, nullptr,
+                         "PlatformThreadTest1");
+  PlatformThread thread2(&NullRunFunctionDeprecated, nullptr,
+                         "PlatformThreadTest2");
+  EXPECT_TRUE(thread1.GetThreadRef() == thread2.GetThreadRef());
+  thread1.Start();
+  thread2.Start();
+  EXPECT_TRUE(thread1.GetThreadRef() != thread2.GetThreadRef());
+  thread2.Stop();
+  thread1.Stop();
+}
+
+TEST(PlatformThreadTest, RunFunctionIsCalledDeprecated) {
+  bool flag = false;
+  PlatformThread thread(&SetFlagRunFunctionDeprecated, &flag,
+                        "RunFunctionIsCalled");
+  thread.Start();
+
+  // At this point, the flag may be either true or false.
+  thread.Stop();
+
+  // We expect the thread to have run at least once.
+  EXPECT_TRUE(flag);
+}
+
 TEST(PlatformThreadTest, StartStop) {
   PlatformThread thread(&NullRunFunction, nullptr, "PlatformThreadTest");
   EXPECT_TRUE(thread.name() == "PlatformThreadTest");
   EXPECT_TRUE(thread.GetThreadRef() == 0);
   thread.Start();
   EXPECT_TRUE(thread.GetThreadRef() != 0);
   thread.Stop();
   EXPECT_TRUE(thread.GetThreadRef() == 0);
 }
 
@@ skipping 12 matching lines @@
   bool flag = false;
   PlatformThread thread(&SetFlagRunFunction, &flag, "RunFunctionIsCalled");
   thread.Start();
 
   // At this point, the flag may be either true or false.
   thread.Stop();
 
   // We expect the thread to have run at least once.
   EXPECT_TRUE(flag);
 }
+
 }  // rtc