Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc

Issue 2708723002: added WebRTC-QuickPerfTest to RampUpTests and CallPerfTests (Closed)
Patch Set: added QuickPerfTest field-trial to NetEq and VideoSender/BWE tests Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/call/call_perf_tests.cc ('k') | webrtc/modules/remote_bitrate_estimator/test/bwe_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc
diff --git a/webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc b/webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc
index 4349a70390355278c8b38ef34216896967c12bc3..885026698dc966d3ccd2a4484c745569fadb9849 100644
--- a/webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc
+++ b/webrtc/modules/audio_coding/neteq/tools/neteq_performance_test.cc
@@ -18,6 +18,7 @@
#include "webrtc/modules/audio_coding/neteq/tools/rtp_generator.h"
#include "webrtc/modules/include/module_common_types.h"
#include "webrtc/system_wrappers/include/clock.h"
+#include "webrtc/system_wrappers/include/field_trial.h"
#include "webrtc/test/testsupport/fileutils.h"
#include "webrtc/typedefs.h"
@@ -26,12 +27,19 @@ using webrtc::test::AudioLoop;
using webrtc::test::RtpGenerator;
using webrtc::WebRtcRTPHeader;
+namespace {
+ const int kQuickTestTimeoutMs = 100000;
stefan-webrtc 2017/02/21 09:35:46 Sounds like a lot to have 100 seconds for a quick
ilnik 2017/02/21 09:46:08 The variable is named runtime_ms, but it is not a
stefan-webrtc 2017/02/21 10:26:03 Ok I would prefer if you moved this to where the
hlundin-webrtc 2017/02/21 10:35:04 Yes, agree with Stefan. This is an unexpected over
+}
+
namespace webrtc {
namespace test {
int64_t NetEqPerformanceTest::Run(int runtime_ms,
int lossrate,
double drift_factor) {
+ if (field_trial::FindFullName("WebRTC-QuickPerfTest") == "Enabled") {
+ runtime_ms = kQuickTestTimeoutMs;
+ }
const std::string kInputFileName =
webrtc::test::ResourcePath("audio_coding/testfile32kHz", "pcm");
const int kSampRateHz = 32000;
« no previous file with comments | « webrtc/call/call_perf_tests.cc ('k') | webrtc/modules/remote_bitrate_estimator/test/bwe_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698