Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1884)

Unified Diff: webrtc/tools/event_log_visualizer/analyzer.cc

Issue 2707383006: GetTransportFeedbackVector() includes unreceived packets, sorted by seq-num (Closed)
Patch Set: . Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/tools/event_log_visualizer/analyzer.cc
diff --git a/webrtc/tools/event_log_visualizer/analyzer.cc b/webrtc/tools/event_log_visualizer/analyzer.cc
index 5e684cf16cdccc376d52e26fe8727b0391e48c74..998c6b025f4733cc35a6369be4a61a1a9d7ddd5c 100644
--- a/webrtc/tools/event_log_visualizer/analyzer.cc
+++ b/webrtc/tools/event_log_visualizer/analyzer.cc
@@ -1049,6 +1049,7 @@ void EventLogAnalyzer::CreateBweSimulationGraph(Plot* plot) {
TransportFeedbackObserver* observer = cc.GetTransportFeedbackObserver();
observer->OnTransportFeedback(*static_cast<rtcp::TransportFeedback*>(
rtcp.packet.get()));
+ // TODO(elad.alon): Modify this (before landing).
std::vector<PacketFeedback> feedback =
observer->GetTransportFeedbackVector();
rtc::Optional<uint32_t> bitrate_bps;
@@ -1184,6 +1185,7 @@ void EventLogAnalyzer::CreateNetworkDelayFeedbackGraph(Plot* plot) {
if (rtcp.type == kRtcpTransportFeedback) {
feedback_adapter.OnTransportFeedback(
*static_cast<rtcp::TransportFeedback*>(rtcp.packet.get()));
+ // TODO(elad.alon): Modify this (before landing).
std::vector<PacketFeedback> feedback =
feedback_adapter.GetTransportFeedbackVector();
for (const PacketFeedback& packet : feedback) {

Powered by Google App Engine
This is Rietveld 408576698