Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1691)

Side by Side Diff: webrtc/modules/congestion_controller/delay_based_bwe.h

Issue 2707383006: GetTransportFeedbackVector() includes unreceived packets, sorted by seq-num (Closed)
Patch Set: Response to CR Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 }; 82 };
83 83
84 Result IncomingPacketFeedback(const PacketFeedback& packet_feedback); 84 Result IncomingPacketFeedback(const PacketFeedback& packet_feedback);
85 Result OnLongFeedbackDelay(int64_t arrival_time_ms); 85 Result OnLongFeedbackDelay(int64_t arrival_time_ms);
86 // Updates the current remote rate estimate and returns true if a valid 86 // Updates the current remote rate estimate and returns true if a valid
87 // estimate exists. 87 // estimate exists.
88 bool UpdateEstimate(int64_t packet_arrival_time_ms, 88 bool UpdateEstimate(int64_t packet_arrival_time_ms,
89 int64_t now_ms, 89 int64_t now_ms,
90 rtc::Optional<uint32_t> acked_bitrate_bps, 90 rtc::Optional<uint32_t> acked_bitrate_bps,
91 uint32_t* target_bitrate_bps); 91 uint32_t* target_bitrate_bps);
92
93 void SortPacketFeedbackVector(const std::vector<PacketFeedback>& input,
94 std::vector<PacketFeedback>* output);
95
92 const bool in_trendline_experiment_; 96 const bool in_trendline_experiment_;
93 const bool in_median_slope_experiment_; 97 const bool in_median_slope_experiment_;
94 98
95 rtc::ThreadChecker network_thread_; 99 rtc::ThreadChecker network_thread_;
96 RtcEventLog* const event_log_; 100 RtcEventLog* const event_log_;
97 Clock* const clock_; 101 Clock* const clock_;
98 std::unique_ptr<InterArrival> inter_arrival_; 102 std::unique_ptr<InterArrival> inter_arrival_;
99 std::unique_ptr<OveruseEstimator> kalman_estimator_; 103 std::unique_ptr<OveruseEstimator> kalman_estimator_;
100 std::unique_ptr<TrendlineEstimator> trendline_estimator_; 104 std::unique_ptr<TrendlineEstimator> trendline_estimator_;
101 std::unique_ptr<MedianSlopeEstimator> median_slope_estimator_; 105 std::unique_ptr<MedianSlopeEstimator> median_slope_estimator_;
(...skipping 13 matching lines...) Expand all
115 int consecutive_delayed_feedbacks_; 119 int consecutive_delayed_feedbacks_;
116 uint32_t last_logged_bitrate_; 120 uint32_t last_logged_bitrate_;
117 BandwidthUsage last_logged_state_; 121 BandwidthUsage last_logged_state_;
118 122
119 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(DelayBasedBwe); 123 RTC_DISALLOW_IMPLICIT_CONSTRUCTORS(DelayBasedBwe);
120 }; 124 };
121 125
122 } // namespace webrtc 126 } // namespace webrtc
123 127
124 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_DELAY_BASED_BWE_H_ 128 #endif // WEBRTC_MODULES_CONGESTION_CONTROLLER_DELAY_BASED_BWE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698