Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Side by Side Diff: webrtc/modules/rtp_rtcp/include/rtp_rtcp_defines.h

Issue 2707383006: GetTransportFeedbackVector() includes unreceived packets, sorted by seq-num (Closed)
Patch Set: SortPacketFeedbackVector moved out of class. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 261 matching lines...) Expand 10 before | Expand all | Expand 10 after
272 size_t payload_size, 272 size_t payload_size,
273 const PacedPacketInfo& pacing_info) 273 const PacedPacketInfo& pacing_info)
274 : creation_time_ms(creation_time_ms), 274 : creation_time_ms(creation_time_ms),
275 arrival_time_ms(arrival_time_ms), 275 arrival_time_ms(arrival_time_ms),
276 send_time_ms(send_time_ms), 276 send_time_ms(send_time_ms),
277 sequence_number(sequence_number), 277 sequence_number(sequence_number),
278 payload_size(payload_size), 278 payload_size(payload_size),
279 pacing_info(pacing_info) {} 279 pacing_info(pacing_info) {}
280 280
281 static constexpr int kNotAProbe = -1; 281 static constexpr int kNotAProbe = -1;
282 static constexpr int64_t kNotReceived = -1;
282 283
283 // NOTE! The variable |creation_time_ms| is not used when testing equality. 284 // NOTE! The variable |creation_time_ms| is not used when testing equality.
284 // This is due to |creation_time_ms| only being used by SendTimeHistory 285 // This is due to |creation_time_ms| only being used by SendTimeHistory
285 // for book-keeping, and is of no interest outside that class. 286 // for book-keeping, and is of no interest outside that class.
286 // TODO(philipel): Remove |creation_time_ms| from PacketFeedback when cleaning 287 // TODO(philipel): Remove |creation_time_ms| from PacketFeedback when cleaning
287 // up SendTimeHistory. 288 // up SendTimeHistory.
288 bool operator==(const PacketFeedback& rhs) const { 289 bool operator==(const PacketFeedback& rhs) const {
289 return arrival_time_ms == rhs.arrival_time_ms && 290 return arrival_time_ms == rhs.arrival_time_ms &&
290 send_time_ms == rhs.send_time_ms && 291 send_time_ms == rhs.send_time_ms &&
291 sequence_number == rhs.sequence_number && 292 sequence_number == rhs.sequence_number &&
292 payload_size == rhs.payload_size && pacing_info == rhs.pacing_info; 293 payload_size == rhs.payload_size && pacing_info == rhs.pacing_info;
293 } 294 }
294 295
295 // Time corresponding to when this object was created. 296 // Time corresponding to when this object was created.
296 int64_t creation_time_ms; 297 int64_t creation_time_ms;
297 // Time corresponding to when the packet was received. Timestamped with the 298 // Time corresponding to when the packet was received. Timestamped with the
298 // receiver's clock. 299 // receiver's clock. For unreceived packet, the sentinel value kNotReceived
300 // is used.
299 int64_t arrival_time_ms; 301 int64_t arrival_time_ms;
300 // Time corresponding to when the packet was sent, timestamped with the 302 // Time corresponding to when the packet was sent, timestamped with the
301 // sender's clock. 303 // sender's clock.
302 int64_t send_time_ms; 304 int64_t send_time_ms;
303 // Packet identifier, incremented with 1 for every packet generated by the 305 // Packet identifier, incremented with 1 for every packet generated by the
304 // sender. 306 // sender.
305 uint16_t sequence_number; 307 uint16_t sequence_number;
306 // Size of the packet excluding RTP headers. 308 // Size of the packet excluding RTP headers.
307 size_t payload_size; 309 size_t payload_size;
308 // Pacing information about this packet. 310 // Pacing information about this packet.
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
405 class TransportSequenceNumberAllocator { 407 class TransportSequenceNumberAllocator {
406 public: 408 public:
407 TransportSequenceNumberAllocator() {} 409 TransportSequenceNumberAllocator() {}
408 virtual ~TransportSequenceNumberAllocator() {} 410 virtual ~TransportSequenceNumberAllocator() {}
409 411
410 virtual uint16_t AllocateSequenceNumber() = 0; 412 virtual uint16_t AllocateSequenceNumber() = 0;
411 }; 413 };
412 414
413 } // namespace webrtc 415 } // namespace webrtc
414 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_DEFINES_H_ 416 #endif // WEBRTC_MODULES_RTP_RTCP_INCLUDE_RTP_RTCP_DEFINES_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698