Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Unified Diff: webrtc/logging/rtc_event_log/rtc_event_log_parser.h

Issue 2705613002: Rename some variables and methods in RTC event log. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/logging/rtc_event_log/rtc_event_log_parser.h
diff --git a/webrtc/logging/rtc_event_log/rtc_event_log_parser.h b/webrtc/logging/rtc_event_log/rtc_event_log_parser.h
index c81b8fb10eea597f95f3158124efb9ceb2982ee6..739ccee220693cc42e070cf91df87e74fac6d60f 100644
--- a/webrtc/logging/rtc_event_log/rtc_event_log_parser.h
+++ b/webrtc/logging/rtc_event_log/rtc_event_log_parser.h
@@ -42,8 +42,8 @@ class ParsedRtcEventLog {
RTP_EVENT = 3,
RTCP_EVENT = 4,
AUDIO_PLAYOUT_EVENT = 5,
- BWE_PACKET_LOSS_EVENT = 6,
- BWE_PACKET_DELAY_EVENT = 7,
+ LOSS_BASED_BWE_UPDATE = 6,
+ DELAY_BASED_BWE_UPDATE = 7,
VIDEO_RECEIVER_CONFIG_EVENT = 8,
VIDEO_SENDER_CONFIG_EVENT = 9,
AUDIO_RECEIVER_CONFIG_EVENT = 10,
@@ -120,8 +120,8 @@ class ParsedRtcEventLog {
// the corresponding output parameters. Each output parameter can be set to
// nullptr if that
// value isn't needed.
- void GetBwePacketLossEvent(size_t index,
- int32_t* bitrate,
+ void GetLossBasedBweUpdate(size_t index,
+ int32_t* bitrate_bps,
uint8_t* fraction_loss,
int32_t* total_packets) const;
@@ -129,8 +129,8 @@ class ParsedRtcEventLog {
// and stores the values in the corresponding output parameters. Each output
// parameter can be set to nullptr if that
// value isn't needed.
- void GetBwePacketDelayEvent(size_t index,
- int32_t* bitrate,
+ void GetDelayBasedBweUpdate(size_t index,
+ int32_t* bitrate_bps,
BandwidthUsage* detector_state) const;
// Reads a audio network adaptation event to a (non-NULL)
« no previous file with comments | « webrtc/logging/rtc_event_log/rtc_event_log.proto ('k') | webrtc/logging/rtc_event_log/rtc_event_log_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698