webrtc/video/video_quality_test.cc - Issue 2705093002: Injectable audio encoders: WebRtcVoiceEngine and company

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/video_quality_test.cc

Issue 2705093002: Injectable audio encoders: WebRtcVoiceEngine and company (Closed)

Patch Set: audio_send_spec made optional<>, EnableAudioNetworkAdapter now called directly on encoder, VAD supp… Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/video/video_quality_test.cc

diff --git a/webrtc/video/video_quality_test.cc b/webrtc/video/video_quality_test.cc

index 6f4fc78d5d51d79db728e7fc008a7f1136b4daf8..3eaa43dd450e7a2f68c79a6e756c80a52f30a5bf 100644

--- a/webrtc/video/video_quality_test.cc

+++ b/webrtc/video/video_quality_test.cc

@@ -1708,8 +1708,10 @@ void VideoQualityTest::SetupAudio(int send_channel_id,

audio_send_config_.min_bitrate_bps = kOpusMinBitrateBps;

audio_send_config_.max_bitrate_bps = kOpusBitrateFbBps;

}

- audio_send_config_.send_codec_spec.codec_inst =

- CodecInst{120, "OPUS", 48000, 960, 2, 64000};

+ // TODO(ossu): "Add stereo here?"

kwiberg-webrtc 2017/03/22 00:00:45 Probably. Looks like it was stereo before.

ossu 2017/04/04 15:36:37 Agreed.

+ audio_send_config_.send_codec_spec =

+ rtc::Optional<AudioSendStream::Config::SendCodecSpec>(

+ {120, {"OPUS", 48000, 2}});

audio_send_stream_ = call->CreateAudioSendStream(audio_send_config_);