Injectable audio encoders: WebRtcVoiceEngine and company

webrtc/media/BUILD.gn

 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("//build/config/linux/pkg_config.gni")
 import("../webrtc.gni")
@@ skipping 24 matching lines @@
 rtc_static_library("rtc_media_base") {
   # TODO(kjellander): Remove (bugs.webrtc.org/6828)
   # Enabling GN check triggers cyclic dependency error:
   #   //webrtc/media:rtc_media_base ->
   #   //webrtc/pc:rtc_pc ->
   #   //webrtc/media:media ->
   #   //webrtc/media:rtc_media_base
   check_includes = false
   defines = []
   libs = []
-  deps = []
+  deps = [
+    "../modules/audio_coding:audio_encoder_factory_interface",

[the sun, 2017/04/07 11:52:56]

Why isn't there anything else in this deps array? Looks like your additions
should be down with the others, line 102-111?

[ossu, 2017/04/10 10:18:39]

Probably an ocular failure on my behalf. I'll move 'em!

+    "../modules/audio_coding:builtin_audio_encoder_factory",
+  ]
   sources = [
     "base/adaptedvideotracksource.cc",
     "base/adaptedvideotracksource.h",
     "base/audiosource.h",
     "base/codec.cc",
     "base/codec.h",
     "base/cryptoparams.h",
     "base/device.h",
     "base/mediachannel.h",
     "base/mediaconstants.cc",
@@ skipping 396 matching lines @@
       "../modules/audio_processing:audio_processing",
       "../modules/video_coding:video_coding_utility",
       "../modules/video_coding:webrtc_vp8",
       "../p2p:rtc_p2p_unittests",
       "../system_wrappers:metrics_default",
       "../test:test_support",
       "../voice_engine:voice_engine",
     ]
   }
 }