Injectable audio encoders: WebRtcVoiceEngine and company

webrtc/voice_engine/channel.h

 /*
  *  Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 152 matching lines @@
 
   // TODO(ossu): Don't use! It's only here to confirm that the decoder factory
   // passed into AudioReceiveStream is the same as the one set when creating the
   // ADM. Once Channel creation is moved into Audio{Send,Receive}Stream this can
   // go.
   const rtc::scoped_refptr<AudioDecoderFactory>& GetAudioDecoderFactory() const;
 
   // Send using this encoder, with this payload type.
   virtual bool SetEncoder(int payload_type,
                           std::unique_ptr<AudioEncoder> encoder);
+  virtual void ModifyEncoder(

[ossu, 2017/04/04 15:36:38]

Needed to plumb this all the way out. Once we get rid of these extra layers, we
can do these calls directly on the encoder object instead.

+      rtc::FunctionView<void(std::unique_ptr<AudioEncoder>*)> modifier);
 
   // API methods
 
   // VoEBase
   int32_t StartPlayout();
   int32_t StopPlayout();
   int32_t StartSend();
   int32_t StopSend();
   int32_t RegisterVoiceEngineObserver(VoiceEngineObserver& observer);
   int32_t DeRegisterVoiceEngineObserver();
@@ skipping 325 matching lines @@
   std::unique_ptr<RateLimiter> retransmission_rate_limiter_;
 
   // TODO(ossu): Remove once GetAudioDecoderFactory() is no longer needed.
   rtc::scoped_refptr<AudioDecoderFactory> decoder_factory_;
 };
 
 }  // namespace voe
 }  // namespace webrtc
 
 #endif  // WEBRTC_VOICE_ENGINE_CHANNEL_H_