Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Issue 2705003002: [MDC roll] Roll Material Components to 2fe5887b69b53ebf78966cc764aadd39c750f453 (Closed)

Created:
3 years, 10 months ago by lpromero
Modified:
3 years, 10 months ago
Reviewers:
mrefaat, sdefresne
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MDC roll] Roll Material Components to 2fe5887b69b53ebf78966cc764aadd39c750f453 Removes MDCCollectionViewCell+Ink category as it was removed in: github.com/material-components/material-components-ios/commit/5db1b8add5e9e77d9439a973cbc9d2d41188d049 BUG=692852 R=sdefresne@chromium.org Review-Url: https://codereview.chromium.org/2705003002 Cr-Commit-Position: refs/heads/master@{#451978} Committed: https://chromium.googlesource.com/chromium/src/+/a15f587cbffe556277ca05a82a9b0eec6b9d1ad7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ios/third_party/material_components_ios/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
lpromero
3 years, 10 months ago (2017-02-20 10:00:12 UTC) #1
lpromero
3 years, 10 months ago (2017-02-21 08:26:50 UTC) #7
mrefaat
lgtm
3 years, 10 months ago (2017-02-21 19:46:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705003002/1
3 years, 10 months ago (2017-02-21 19:48:31 UTC) #13
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-21 19:48:33 UTC) #15
sdefresne
lgtm Sorry for the delay, missed initial ping.
3 years, 10 months ago (2017-02-22 09:07:44 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2705003002/1
3 years, 10 months ago (2017-02-22 09:08:43 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 10:36:55 UTC) #21
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a15f587cbffe556277ca05a82a9b...

Powered by Google App Engine
This is Rietveld 408576698