Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: webrtc/video/end_to_end_tests.cc

Issue 2704183002: Revert of Revert Make the new jitter buffer the default jitter buffer. (Closed)
Patch Set: Rebase Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/modules/video_coding/video_receiver.cc ('k') | webrtc/video/receive_statistics_proxy.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2013 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 #include <algorithm> 10 #include <algorithm>
(...skipping 1259 matching lines...) Expand 10 before | Expand all | Expand 10 after
1270 } test(rtp_history_ms); 1270 } test(rtp_history_ms);
1271 1271
1272 RunBaseTest(&test); 1272 RunBaseTest(&test);
1273 } 1273 }
1274 1274
1275 TEST_P(EndToEndTest, ReceivesPliAndRecoversWithNack) { 1275 TEST_P(EndToEndTest, ReceivesPliAndRecoversWithNack) {
1276 ReceivesPliAndRecovers(1000); 1276 ReceivesPliAndRecovers(1000);
1277 } 1277 }
1278 1278
1279 TEST_P(EndToEndTest, ReceivesPliAndRecoversWithoutNack) { 1279 TEST_P(EndToEndTest, ReceivesPliAndRecoversWithoutNack) {
1280 // This test makes no sense for the new video jitter buffer.
1281 if (GetParam() == new_jb_enabled)
1282 return;
1283 ReceivesPliAndRecovers(0); 1280 ReceivesPliAndRecovers(0);
1284 } 1281 }
1285 1282
1286 TEST_P(EndToEndTest, UnknownRtpPacketGivesUnknownSsrcReturnCode) { 1283 TEST_P(EndToEndTest, UnknownRtpPacketGivesUnknownSsrcReturnCode) {
1287 class PacketInputObserver : public PacketReceiver { 1284 class PacketInputObserver : public PacketReceiver {
1288 public: 1285 public:
1289 explicit PacketInputObserver(PacketReceiver* receiver) 1286 explicit PacketInputObserver(PacketReceiver* receiver)
1290 : receiver_(receiver), delivered_packet_(false, false) {} 1287 : receiver_(receiver), delivered_packet_(false, false) {}
1291 1288
1292 bool Wait() { return delivered_packet_.Wait(kDefaultTimeoutMs); } 1289 bool Wait() { return delivered_packet_.Wait(kDefaultTimeoutMs); }
(...skipping 1801 matching lines...) Expand 10 before | Expand all | Expand 10 after
3094 std::map<std::string, bool> send_stats_filled_; 3091 std::map<std::string, bool> send_stats_filled_;
3095 3092
3096 std::vector<uint32_t> expected_receive_ssrcs_; 3093 std::vector<uint32_t> expected_receive_ssrcs_;
3097 std::set<uint32_t> expected_send_ssrcs_; 3094 std::set<uint32_t> expected_send_ssrcs_;
3098 std::string expected_cname_; 3095 std::string expected_cname_;
3099 3096
3100 rtc::Event check_stats_event_; 3097 rtc::Event check_stats_event_;
3101 ReceiveStreamRenderer receive_stream_renderer_; 3098 ReceiveStreamRenderer receive_stream_renderer_;
3102 } test; 3099 } test;
3103 3100
3104 // TODO(philipel): Implement statistics for the new video jitter buffer.
3105 if (GetParam() == new_jb_enabled)
3106 return;
3107
3108 RunBaseTest(&test); 3101 RunBaseTest(&test);
3109 } 3102 }
3110 3103
3111 class RtcpXrObserver : public test::EndToEndTest { 3104 class RtcpXrObserver : public test::EndToEndTest {
3112 public: 3105 public:
3113 RtcpXrObserver(bool enable_rrtr, bool enable_target_bitrate) 3106 RtcpXrObserver(bool enable_rrtr, bool enable_target_bitrate)
3114 : EndToEndTest(test::CallTest::kDefaultTimeoutMs), 3107 : EndToEndTest(test::CallTest::kDefaultTimeoutMs),
3115 enable_rrtr_(enable_rrtr), 3108 enable_rrtr_(enable_rrtr),
3116 enable_target_bitrate_(enable_target_bitrate), 3109 enable_target_bitrate_(enable_target_bitrate),
3117 sent_rtcp_sr_(0), 3110 sent_rtcp_sr_(0),
(...skipping 1072 matching lines...) Expand 10 before | Expand all | Expand 10 after
4190 std::unique_ptr<VideoEncoder> encoder_; 4183 std::unique_ptr<VideoEncoder> encoder_;
4191 std::unique_ptr<VideoDecoder> decoder_; 4184 std::unique_ptr<VideoDecoder> decoder_;
4192 rtc::CriticalSection crit_; 4185 rtc::CriticalSection crit_;
4193 int recorded_frames_ GUARDED_BY(crit_); 4186 int recorded_frames_ GUARDED_BY(crit_);
4194 } test(this); 4187 } test(this);
4195 4188
4196 RunBaseTest(&test); 4189 RunBaseTest(&test);
4197 } 4190 }
4198 4191
4199 } // namespace webrtc 4192 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/modules/video_coding/video_receiver.cc ('k') | webrtc/video/receive_statistics_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698