webrtc/modules/audio_coding/audio_network_adaptor/controller_manager_unittest.cc - Issue 2703353002: Change frame length on very low bandwidth.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/audio_coding/audio_network_adaptor/controller_manager_unittest.cc

Issue 2703353002: Change frame length on very low bandwidth. (Closed)

Patch Set: Responsd to comments. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc ('k') | webrtc/modules/audio_coding/audio_network_adaptor/frame_length_controller.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/audio_coding/audio_network_adaptor/controller_manager_unittest.cc

diff --git a/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager_unittest.cc b/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager_unittest.cc

index 1336166107755ec3ea6a125f58c1e57e2b3cefef..ed96e1b9c689ec37793d9306cfeccd544de2b399 100644

--- a/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager_unittest.cc

+++ b/webrtc/modules/audio_coding/audio_network_adaptor/controller_manager_unittest.cc

@@ -270,6 +270,7 @@ constexpr size_t kIntialChannelsToEncode = 1;

constexpr bool kInitialDtxEnabled = true;

constexpr bool kInitialFecEnabled = true;

constexpr int kInitialFrameLengthMs = 60;

+constexpr int kMinBitrateBps = 6000;

ControllerManagerStates CreateControllerManager(

const std::string& config_string) {

@@ -279,8 +280,9 @@ ControllerManagerStates CreateControllerManager(

const std::vector<int> encoder_frame_lengths_ms = {20, 60};

states.controller_manager = ControllerManagerImpl::Create(

config_string, kNumEncoderChannels, encoder_frame_lengths_ms,

- kIntialChannelsToEncode, kInitialFrameLengthMs, kInitialBitrateBps,

- kInitialFecEnabled, kInitialDtxEnabled, states.simulated_clock.get());

+ kMinBitrateBps, kIntialChannelsToEncode, kInitialFrameLengthMs,

+ kInitialBitrateBps, kInitialFecEnabled, kInitialDtxEnabled,

+ states.simulated_clock.get());

return states;

}