Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 2700693002: [MD Bookmarks] Expose chrome.bookmarks.import/export to MD Bookmarks (Closed)

Created:
3 years, 10 months ago by rongjie
Modified:
3 years, 10 months ago
Reviewers:
tsergeant, Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Bookmarks] Expose chrome.bookmarks.import/export to MD Bookmarks BUG=658980, 692848 Review-Url: https://codereview.chromium.org/2700693002 Cr-Commit-Position: refs/heads/master@{#451974} Committed: https://chromium.googlesource.com/chromium/src/+/78cb58e46b5b386904878be7847399b14f0e4d63

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M chrome/common/extensions/api/_api_features.json View 1 chunk +18 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
rongjie
3 years, 10 months ago (2017-02-16 01:07:02 UTC) #1
rongjie
Updated reviewers, hope I am calling the right persons this time.
3 years, 10 months ago (2017-02-16 08:21:45 UTC) #4
Devlin
lgtm
3 years, 10 months ago (2017-02-17 23:35:07 UTC) #5
tsergeant
Ah, sorry, this slipped my mind As discussed over email, lgtm
3 years, 10 months ago (2017-02-19 21:58:02 UTC) #6
rongjie
Ping?
3 years, 10 months ago (2017-02-22 02:33:24 UTC) #7
tsergeant
You've got all the code reviews you need, so I'll click the 'Commit' checkbox for ...
3 years, 10 months ago (2017-02-22 02:49:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700693002/1
3 years, 10 months ago (2017-02-22 02:50:38 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-22 04:54:33 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2700693002/1
3 years, 10 months ago (2017-02-22 08:56:28 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 10:18:47 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/78cb58e46b5b386904878be78473...

Powered by Google App Engine
This is Rietveld 408576698