Add optional visualization file writers to VideoProcessor tests.

webrtc/test/testsupport/frame_writer_unittest.cc

Index: webrtc/test/testsupport/frame_writer_unittest.cc
diff --git a/webrtc/test/testsupport/frame_writer_unittest.cc b/webrtc/test/testsupport/frame_writer_unittest.cc
index 59173bdfaae03f69171b801efd8c399d020b9dfa..b58d28bebe1b89782196adabd5eb5ffb5a190870 100644
--- a/webrtc/test/testsupport/frame_writer_unittest.cc
+++ b/webrtc/test/testsupport/frame_writer_unittest.cc
@@ -16,7 +16,9 @@
 namespace webrtc {
 namespace test {
 
-const size_t kFrameLength = 1000;
+const size_t kFrameWidth = 50;
+const size_t kFrameHeight = 20;
+const size_t kFrameLength = 3 * kFrameWidth * kFrameHeight / 2;  // I420.
 
 class FrameWriterTest: public testing::Test {
  protected:
@@ -25,7 +27,8 @@ class FrameWriterTest: public testing::Test {
   void SetUp() {
     temp_filename_ = webrtc::test::TempFilename(webrtc::test::OutputPath(),
                                                 "frame_writer_unittest");
-    frame_writer_ = new FrameWriterImpl(temp_filename_, kFrameLength);
+    frame_writer_ =
+        new YuvFrameWriterImpl(temp_filename_, kFrameWidth, kFrameHeight);
     ASSERT_TRUE(frame_writer_->Init());
   }
   void TearDown() {
@@ -38,16 +41,16 @@ class FrameWriterTest: public testing::Test {
 };
 
 TEST_F(FrameWriterTest, InitSuccess) {
-  FrameWriterImpl frame_writer(temp_filename_, kFrameLength);
+  YuvFrameWriterImpl frame_writer(temp_filename_, kFrameWidth, kFrameHeight);
   ASSERT_TRUE(frame_writer.Init());
   ASSERT_EQ(kFrameLength, frame_writer.FrameLength());
 }
 
 TEST_F(FrameWriterTest, WriteFrame) {
   uint8_t buffer[kFrameLength];
-  memset(buffer, 9, kFrameLength);  // Write lots of 9s to the buffer
+  memset(buffer, 9, kFrameLength);  // Write lots of 9s to the buffer.
   bool result = frame_writer_->WriteFrame(buffer);
-  ASSERT_TRUE(result);  // success
+  ASSERT_TRUE(result);
   // Close the file and verify the size.
   frame_writer_->Close();
   ASSERT_EQ(kFrameLength, GetFileSize(temp_filename_));
@@ -55,7 +58,7 @@ TEST_F(FrameWriterTest, WriteFrame) {
 
 TEST_F(FrameWriterTest, WriteFrameUninitialized) {
   uint8_t buffer[3];
-  FrameWriterImpl frame_writer(temp_filename_, kFrameLength);
+  YuvFrameWriterImpl frame_writer(temp_filename_, kFrameWidth, kFrameHeight);
   ASSERT_FALSE(frame_writer.WriteFrame(buffer));
 }
 

[kjellander_webrtc, 2017/02/19 09:02:37]

Please add unit tests for Y4mFrameWriterImpl as well.

[brandtr, 2017/02/20 13:17:31]

Done.