Index: webrtc/test/testsupport/yuv_frame_writer_unittest.cc |
diff --git a/webrtc/test/testsupport/frame_writer_unittest.cc b/webrtc/test/testsupport/yuv_frame_writer_unittest.cc |
similarity index 43% |
rename from webrtc/test/testsupport/frame_writer_unittest.cc |
rename to webrtc/test/testsupport/yuv_frame_writer_unittest.cc |
index 59173bdfaae03f69171b801efd8c399d020b9dfa..5e3cc5c9c98d0c88f1365c06f4ef8deca279bb94 100644 |
--- a/webrtc/test/testsupport/frame_writer_unittest.cc |
+++ b/webrtc/test/testsupport/yuv_frame_writer_unittest.cc |
@@ -1,5 +1,5 @@ |
/* |
- * Copyright (c) 2011 The WebRTC project authors. All Rights Reserved. |
+ * Copyright (c) 2017 The WebRTC project authors. All Rights Reserved. |
* |
* Use of this source code is governed by a BSD-style license |
* that can be found in the LICENSE file in the root of the source |
@@ -8,55 +8,60 @@ |
* be found in the AUTHORS file in the root of the source tree. |
*/ |
-#include "webrtc/test/testsupport/frame_writer.h" |
+#include <memory> |
#include "webrtc/test/gtest.h" |
#include "webrtc/test/testsupport/fileutils.h" |
+#include "webrtc/test/testsupport/frame_writer.h" |
namespace webrtc { |
namespace test { |
-const size_t kFrameLength = 1000; |
+namespace { |
+const size_t kFrameWidth = 50; |
+const size_t kFrameHeight = 20; |
+const size_t kFrameLength = 3 * kFrameWidth * kFrameHeight / 2; // I420. |
+} // namespace |
-class FrameWriterTest: public testing::Test { |
+class YuvFrameWriterTest : public testing::Test { |
protected: |
- FrameWriterTest() {} |
- virtual ~FrameWriterTest() {} |
- void SetUp() { |
+ YuvFrameWriterTest() = default; |
+ ~YuvFrameWriterTest() override = default; |
+ |
+ void SetUp() override { |
temp_filename_ = webrtc::test::TempFilename(webrtc::test::OutputPath(), |
- "frame_writer_unittest"); |
- frame_writer_ = new FrameWriterImpl(temp_filename_, kFrameLength); |
+ "yuv_frame_writer_unittest"); |
+ frame_writer_.reset( |
+ new YuvFrameWriterImpl(temp_filename_, kFrameWidth, kFrameHeight)); |
ASSERT_TRUE(frame_writer_->Init()); |
} |
- void TearDown() { |
- delete frame_writer_; |
- // Cleanup the temporary file. |
- remove(temp_filename_.c_str()); |
- } |
- FrameWriter* frame_writer_; |
+ |
+ void TearDown() override { remove(temp_filename_.c_str()); } |
+ |
+ std::unique_ptr<FrameWriter> frame_writer_; |
std::string temp_filename_; |
}; |
-TEST_F(FrameWriterTest, InitSuccess) { |
- FrameWriterImpl frame_writer(temp_filename_, kFrameLength); |
- ASSERT_TRUE(frame_writer.Init()); |
- ASSERT_EQ(kFrameLength, frame_writer.FrameLength()); |
+TEST_F(YuvFrameWriterTest, InitSuccess) {} |
+ |
+TEST_F(YuvFrameWriterTest, FrameLength) { |
+ EXPECT_EQ(kFrameLength, frame_writer_->FrameLength()); |
} |
-TEST_F(FrameWriterTest, WriteFrame) { |
+TEST_F(YuvFrameWriterTest, WriteFrame) { |
uint8_t buffer[kFrameLength]; |
- memset(buffer, 9, kFrameLength); // Write lots of 9s to the buffer |
+ memset(buffer, 9, kFrameLength); // Write lots of 9s to the buffer. |
bool result = frame_writer_->WriteFrame(buffer); |
- ASSERT_TRUE(result); // success |
- // Close the file and verify the size. |
+ ASSERT_TRUE(result); |
+ |
frame_writer_->Close(); |
- ASSERT_EQ(kFrameLength, GetFileSize(temp_filename_)); |
+ EXPECT_EQ(kFrameLength, GetFileSize(temp_filename_)); |
} |
-TEST_F(FrameWriterTest, WriteFrameUninitialized) { |
- uint8_t buffer[3]; |
- FrameWriterImpl frame_writer(temp_filename_, kFrameLength); |
- ASSERT_FALSE(frame_writer.WriteFrame(buffer)); |
+TEST_F(YuvFrameWriterTest, WriteFrameUninitialized) { |
+ uint8_t buffer[kFrameLength]; |
+ YuvFrameWriterImpl frame_writer(temp_filename_, kFrameWidth, kFrameHeight); |
+ EXPECT_FALSE(frame_writer.WriteFrame(buffer)); |
} |
} // namespace test |